-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version 1.0.0 #53
Comments
@JamesHenry Any chance You could publish new version to |
per the definition of semver, publishing I'll be looking at pushing a new version within the next few days. |
@bradzacher Amazing, thanks. |
@bradzacher not to be rude but technically before 1.0.0 the rules of semver are actually looser than after. Usually it symbolizes "stable for production". The https://semver.org/ website does have an FAQ with some details. This lib is for sure being used in production so it is probably close to 1.0.0. However I expect there are a lot of changes coming so maybe plan a few more releases then 1.0.0. So glad your taking this over! I am quite slammed as I work in eCommerce but after Black Friday should have sometime to do more than just play the peanut gallery. |
Would we want to complete the remaining rules in #5 as part of a 1.0.0 release? |
@corbinu I didn't actually know that, thanks! TBH I'm not 100% comfortable releasing as a 1.0.0 "stable" because of the number of issues that keep popping up with @macklinu we probably need to define the goals of the plugin. Regardless, it's probably a good idea to assess the severity/impact of the current known bugs first so we can decide if we are "production stable". I went through last night and tagged all the current issues appropriately. If you anyone wants to help; feel free to assign yourself to ones you're investigating so we don't double dip on effort. |
@bradzacher The single most important thing before 1.0.0 can be considered IMO is bringing things up to date with advancements in the parser. It is very out of date right now. This PR in particular has major ramifications for the plugin: eslint/typescript-eslint-parser#540 |
thanks @JamesHenry. I opened #166 last night to track the upgrade. We might want to add a peer dep (or actual dep) to help keep it tighter and make it easier for users to know what version to use. I should create a milestone so we can track everything we want for a 1.0.0... |
Awesome
…On Fri, 16 Nov 2018 at 20:03, Brad Zacher ***@***.***> wrote:
thanks @JamesHenry <https://github.com/JamesHenry>. I opened #166
<bradzacher/eslint-plugin-typescript#166> last
night to track the upgrade.
definitely will have to address that for the 1.0.0.
We might want to add a peer dep (or actual dep) to help keep it tighter
and make it easier for users to know what version to use.
I should create a milestone so we can track everything we want for a
1.0.0...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<https://github.com/bradzacher/eslint-plugin-typescript/issues/151#issuecomment-439573183>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA29qyokHW8B8ldiBVrTQtDOpa3HrMcXks5uv2BigaJpZM4VzbDa>
.
|
woo hoo 🎉 Only a few more things to tidy up for the 1.0.0 release! https://github.com/bradzacher/eslint-plugin-typescript/milestone/1 |
i started adding missing informations to AST, they are going to be required to make some of tslint rules.
but this is not going to be available soon 😞 |
I was just looking at We should open an issue when we do the release to make sure they correct to the new parser ref |
any info about v1.0? i want to use this recently. |
we are almost there, we did alot of work in this weekend, you can see remaining tasks in milestone you can help us by giving feedback for: recommended preset |
@bradzacher @j-f1 what do you think about releasing beta version of package before we will go for 1.0.0 that we can get feedback from community about adjustments and errors? |
Yes indeed! I'll be first publishing |
|
@bradzacher do we have any tasks left to do or we just have bug fixes? |
what do you guys think about disabling |
I would agree I have seen a lot of different formats |
With most of the rules, we look to the typescript docs to figure out what the advice on what is best practice. The typescript team doesn't prefix names with I https://www.typescriptlang.org/docs/handbook/interfaces.html Using However typescript has no such legacy. And interfaces exist purely as a marker for object shapes. Additionally interfaces are mostly interchangeable with types. The interchangeability coupled with the fact that they are compile time only makes the I name prefix an antipattern in TS (much like Hungarian notation!). |
|
Alrighty everyone. People have been using it for a few weeks now and there aren't any open issues outside of parser bugs. We could potentially wait for the new parser version to release to fix some of those open issues, but looking at them; it looks like they're rarer edge cases. Thoughts? Objections? |
|
Hey there! I see you're baking in the parser - will This plugin allowed us to drop tslint at work, awesome job! 👍 (full proper support for TS in |
@SimenB, we are improving compatibility of AST between babel and typescript-eslint-parser
|
Also, our parser will have type metadata from TS, which Babel will probably never have. |
Thanks for the replies! |
@SimenB Unless I'm mistaken, you don't get any additional features from using babel-eslint, just support for new language features? As long as you're not using any super duper bleeding edge JS features via babel transforms, then the typescript parser should work fine across your entire codebase (even on .js files). |
using Flow |
Should we switch the |
@SimenB you can specify separate parsers for extensions with eslint overrides. for js/jsx use babel for ts, tsx |
@j-f1 typescript provides/will provide type informations for js files |
Yeah, I'll to that. Thanks for the response! |
PR to |
This will likely be the final RC release for 1.0.0 |
|
Hi, is it possible to change peer dependency on TypeScript package from |
We’re going to be migrating this repo too @ivanvoznyakovsky. @stekycz We’ll probably do that once we make sure our parser supports TypeScript 3.2. |
The plugin was merged FYI, and all packages are using TypeScript 3.2 :) |
I'll make a proper announcement in a short while. |
@stekycz note that typescript doesn't completely follow true semver (they often release small breaking changes with minor version bumps), so having an open range on |
Version 1.0.0 was released :) |
Any reason to hold off on this?
The package appears to be stable.
Hijacking OP for visibility (@bradzacher)
We're actively working on it (and almost there!)
You can track the progress here: https://github.com/bradzacher/eslint-plugin-typescript/milestone/1
The text was updated successfully, but these errors were encountered: