Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: [@typescript-eslint/no-unused-vars] not collect used types on satisfies operator #6057

Closed
4 tasks done
YuseiUeno opened this issue Nov 22, 2022 · 3 comments · Fixed by #6059
Closed
4 tasks done
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin

Comments

@YuseiUeno
Copy link
Contributor

Before You File a Bug Report Please Confirm You Have Done The Following...

  • I have tried restarting my IDE and the issue persists.
  • I have updated to the latest version of the packages.
  • I have searched for related issues and found none that matched my issue.
  • I have read the FAQ and my problem is not listed.

Playground Link

https://typescript-eslint.io/play/#ts=4.9.3&jsx=true&sourceType=module&showAST=es&code=C4TwDgpgBAwg9gGzgJwM5QLxQETIgE2ygB8cBzPCAOyNOwCMEBXCbAbgCgPRIoAlAOIAhTFADaefAC4oVJgFt6EZABooFCNRlzFytYxbaFS5AF1OHAMZwqqYFDABDBBGDBoWAN4coUSTLEAJgBWYLUABgjTFR91SioZbABicPCAMzTU7BjfAwgAyKhCkODTDgBfKFRHYABLVDTaiHQ+CGtkfAAeeCQ0NTtkWqoyEn5hAD42IA&eslintrc=N4KABBYEQE4K4BsCmBnKAuMpI8lAdgPYC0c+cKSAJsQG4CGMamUhAZm1ADTi45QABAC4BPAA6oAxjACWYocVQIZ+IQHoipcpRoMmGaAHdG+KLwgBfEBaA

Repro Code

type Colors = "red" | "green" | "blue";
type RGB = [red: number, green: number, blue: number];
// Above types error by @typescript-eslint/no-unused-vars

const palette = {
  red: [255, 0, 0],
  green: "#00ff00",
  blue: [0, 0, 255]
} satisfies Record<Colors, string | RGB>;

ESLint Config

module.exports = {
  parser: "@typescript-eslint/parser",
  rules: {
          "no-unused-vars": "off",
          "@typescript-eslint/no-unused-vars": "warn"
  },
};

tsconfig

No response

Expected Result

To collect use type if use on satisfies operator

Actual Result

error 'Colors' is defined but never used @typescript-eslint/no-unused-vars
error 'RGB' is defined but never used @typescript-eslint/no-unused-vars

Additional Info

No response

Versions

package version
@typescript-eslint/eslint-plugin 5.44.0
@typescript-eslint/parser 5.44.0
TypeScript 4.9.3
ESLint 8.28.0
node 18.12.1
@YuseiUeno YuseiUeno added bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin triage Waiting for maintainers to take a look labels Nov 22, 2022
@Josh-Cena Josh-Cena added accepting prs Go ahead, send a pull request that resolves this issue and removed triage Waiting for maintainers to take a look labels Nov 22, 2022
@Josh-Cena
Copy link
Member

As always—new syntax needs updates to the scope manager. I really wish this can be done as part of the parser update.

@bradzacher
Copy link
Member

Forgot this when I merged support for satisfies.
It's too easy to forget this when we're adding new syntax!
Unfortunately I don't know if there's a good way to catch this ahead of time..

@Josh-Cena
Copy link
Member

Add it to the TS release tracking issue template? ^^

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepting prs Go ahead, send a pull request that resolves this issue bug Something isn't working package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
3 participants