Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try out v6 beta on various important community repos #6760

Closed
JoshuaKGoldberg opened this issue Mar 24, 2023 · 12 comments
Closed

Try out v6 beta on various important community repos #6760

JoshuaKGoldberg opened this issue Mar 24, 2023 · 12 comments
Assignees
Milestone

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Mar 24, 2023

V6 is ready for public testing (hooray! https://typescript-eslint.io/blog/announcing-typescript-eslint-v6-beta 馃帀) and we want to make sure we try it out on lots of projects. It'd be particularly valuable to try out projects that are:

  • Large enough to exercise test cases (think >100 source files)
  • Popular enough to get visibility for the v6 beta in front of many people (think >1000 GH stars)

I'm thinking to start, at least:

For each of these projects, we should see:

Filing this tracking issue to make sure we do this before releasing v6 as stable.

If you've got a project that matches those criteria & want to get it added to the list, let us know! We'd be happy to work with you.

@JoshuaKGoldberg JoshuaKGoldberg added the blocked by another PR PRs which are ready to go but waiting on another PR label Mar 24, 2023
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Mar 24, 2023
@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Mar 24, 2023
@RebeccaStevens

This comment was marked as off-topic.

@JoshuaKGoldberg

This comment was marked as off-topic.

@fisker
Copy link
Contributor

fisker commented Apr 7, 2023

Prettier

prettier/prettier#14429

Still waiting for #6723

@JoshuaKGoldberg
Copy link
Member Author

JoshuaKGoldberg commented Apr 27, 2023

Aside: chatted with @jakebailey today who gave a tentative personal 馃憤 to at least trying v6 out on the TypeScript codebase. If I have time I'll try to look into overhauling their config to use type-aware rules only in smaller, not-so-performance-killing files (e.g. not src/checker.ts).

@JoshuaKGoldberg JoshuaKGoldberg removed the blocked by another PR PRs which are ready to go but waiting on another PR label Jun 18, 2023
@JoshuaKGoldberg
Copy link
Member Author

#7110 is merged into the v6 branch, #7111 is fixed, and https://www.npmjs.com/package/@typescript-eslint/eslint-plugin/v/6.0.0-alpha.158 is published. I'll start on this now! 馃殌

@fisker
Copy link
Contributor

fisker commented Jun 19, 2023

I want give an update here, we (Prettier) can remove all the invalid node checks after upgrade to latest v6, so we can now use parse dirctly instead of parseWithNodeMaps. I think this method was added because Prettier need it at that moment, feel free to remove it if you think it's unnecessary to keep.

@nicolo-ribaudo
Copy link

I don't know exactly what what we need to update in our configs to try this, but I would happily review a PR trying it out in Babel.

@JoshuaKGoldberg
Copy link
Member Author

JoshuaKGoldberg commented Jun 21, 2023

Ah amazing thanks @nicolo-ribaudo! I'll send a draft PR :)

Edit: babel/babel#15716

@nickmccurdy
Copy link

nickmccurdy commented Jun 23, 2023

How about Vite and Vitest (using @antfu/eslint-config)?

@JoshuaKGoldberg JoshuaKGoldberg pinned this issue Jun 23, 2023
@JoshuaKGoldberg JoshuaKGoldberg unpinned this issue Jun 23, 2023
@JoshuaKGoldberg
Copy link
Member Author

@nickmccurdy a great idea for next time, thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 8, 2023
@typescript-eslint typescript-eslint unlocked this conversation Jul 12, 2023
@JoshuaKGoldberg
Copy link
Member Author

Per sveltejs/kit#10371, looks like Sveltekit would be a good one to add too. :)

@JoshuaKGoldberg
Copy link
Member Author

Two more for the list:

  • Qwik
  • Redwood

...I'll put up a GitHub Discussion to keep this existing longer-term.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants