Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo: deprecate no-magic-numbers #8790

Closed
Martinspire opened this issue Mar 28, 2024 · 1 comment
Closed

Repo: deprecate no-magic-numbers #8790

Martinspire opened this issue Mar 28, 2024 · 1 comment
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs wontfix This will not be worked on

Comments

@Martinspire
Copy link

Suggestion

In a previous issue it was stated that this is a stylistic rule that will not be maintained. Therefore it should be marked as deprecated so the stylistic team can take over

Issue about numbers in array not being ignored:
#8102

Issue on stylistic about it not being deprecated:
eslint-stylistic/eslint-stylistic#238

@Martinspire Martinspire added repo maintenance things to do with maintenance of the repo, and not with code/docs triage Waiting for maintainers to take a look labels Mar 28, 2024
@bradzacher
Copy link
Member

it was stated that this is a stylistic rule that will not be maintained

That's not what I said at all. I said

we aren't looking to deviate from the base rules enforced style. Instead the goal is to augment the existing style with support for TS features that align with the style.

I also said

[The rule is] considered feature complete and thus feature frozen by both us an eslint core.

Being feature frozen and unmaintained are very, very different things.
We will continue to enhance it with new TS features that align with the existing style and we will fix bugs as reported. We will also keep it in sync with the base rule as it changes.

We are just not accepting any new features.

If the base rule is deprecated we'll follow suit. But otherwise there's no reason to deprecate it.

If another plugin would like to fork it to add new features - they're free to do so at any time.

@bradzacher bradzacher closed this as not planned Won't fix, can't repro, duplicate, stale Mar 28, 2024
@bradzacher bradzacher added wontfix This will not be worked on and removed triage Waiting for maintainers to take a look labels Mar 28, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants