Feature Request: Extending @typescript-eslint/no-magic-numbers to allow for readonly number[]

[Samuel-Therrien-Beslogic]

Clear and concise description of the problem

There's a use case that comes up once in a while to define "magic" numbers in an array that itself is meant to be used as a constant.

Suggested solution

Copied from typescript-eslint/typescript-eslint#8102 . Thoughts on allowing (can be locked behind an option) the following?

Fail

const DEFAULT_PAGE_LENGTH = [5, 10, 25, 100]

class MyCLass {
  readonly DEFAULT_PAGE_LENGTH = [5, 10, 25, 100]
}

let DEFAULT_PAGE_LENGTH = [5, 10, 25, 100] as const

class MyCLass {
  DEFAULT_PAGE_LENGTH = [5, 10, 25, 100] as const
}

Pass

const DEFAULT_PAGE_LENGTH = [5, 10, 25, 100] as const

class MyCLass {
  readonly DEFAULT_PAGE_LENGTH = [5, 10, 25, 100] as const
}

Alternative

The alternative to a eslint-disable comment really isn't preferable and really verbose:

const STEP_1 = 5
const STEP_2 = 10
const STEP_3 = 25
const STEP_4 = 10
const DEFAULT_PAGE_LENGTH = [STEP_1 , STEP_2 , STEP_3 , STEP_4]

Additional context

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guide.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

Contributes

• If this feature request is accepted, I am willing to submit a PR to fix this issue

[antfu]

Well, no-magic-number does not seem to be part of this project.

[antfu]

As stated in #26 (comment), we don't have a plan to migrate rules if eslint/ts-eslint teams are not deprecating them. Close if for now.

[Martinspire]

I've added the request to deprecate the issue since I also like to see this being a feature of this rule.