Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Add v8 projectService name to withoutProjectParserOptions #9286

Closed
4 tasks done
JoshuaKGoldberg opened this issue Jun 6, 2024 · 1 comment
Closed
4 tasks done

Enhancement: Add v8 projectService name to withoutProjectParserOptions #9286

JoshuaKGoldberg opened this issue Jun 6, 2024 · 1 comment
Labels
enhancement New feature or request locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. team assigned A member of the typescript-eslint team should work on this.
Milestone
8.0.0

Comments

@JoshuaKGoldberg
Copy link
Member

JoshuaKGoldberg commented Jun 6, 2024 •
edited

Before You File a Proposal Please Confirm You Have Done The Following...

Relevant Package

typescript-estree

My proposal is suitable for this project

  • I believe my proposal would be useful to the broader TypeScript community (meaning it is not a niche proposal).

Description

#9233 was sent into the main branch (our v7 line), which calls the new project service EXPERIMENTAL_useProjectService. But in v8, as of #9084, we now call it projectService. Which means we'll need to also remove that key too!

FYI @fpapado as a heads up. #9233 was perfect as-is. 🙂

Additional Info

Assigning to myself as I was just touching up this file to merge from main.

💖
@JoshuaKGoldberg JoshuaKGoldberg added enhancement New feature or request team assigned A member of the typescript-eslint team should work on this. labels Jun 6, 2024
@JoshuaKGoldberg JoshuaKGoldberg added this to the 8.0.0 milestone Jun 6, 2024
@JoshuaKGoldberg JoshuaKGoldberg mentioned this issue Jun 6, 2024
Merged
3 tasks
@JoshuaKGoldberg
Copy link
Member Author

#9287 was merged into v8. ✔️

@github-actions github-actions bot added the locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. label Jun 17, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request locked due to age Please open a new issue if you'd like to say more. See https://typescript-eslint.io/contributing. team assigned A member of the typescript-eslint team should work on this.
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
1 participant
@JoshuaKGoldberg