Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [unbound-method] support constructor binding #1105

Closed

Conversation

sergey-shulyak
Copy link

@sergey-shulyak sergey-shulyak commented Oct 18, 2019

fix #636

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sergey-shulyak!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@sergey-shulyak sergey-shulyak changed the title fix(eslint-plugin): fix unbound metod triggering on class method bind fix(eslint-plugin): fix unbound method triggering on class method bind Oct 18, 2019
@codecov
Copy link

codecov bot commented Oct 18, 2019

Codecov Report

Merging #1105 into master will decrease coverage by 0.02%.
The diff coverage is 90.9%.

@@            Coverage Diff             @@
##           master    #1105      +/-   ##
==========================================
- Coverage   94.09%   94.07%   -0.03%     
==========================================
  Files         120      120              
  Lines        5203     5216      +13     
  Branches     1443     1444       +1     
==========================================
+ Hits         4896     4907      +11     
- Misses        176      177       +1     
- Partials      131      132       +1
Impacted Files Coverage Δ
packages/typescript-estree/src/parser.ts 95.61% <100%> (+0.03%) ⬆️
...pt-estree/src/create-program/createWatchProgram.ts 93.16% <100%> (+0.17%) ⬆️
...ges/typescript-estree/src/create-program/shared.ts 78.57% <72.72%> (-4.77%) ⬇️

Comment on lines +114 to +115
case AST_NODE_TYPES.AssignmentExpression:
return isBindCalled(parent.right);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only doing this on assignment expressions is too strict of a check.

I.e. these cases will be missed.

myFunc(this.clazz.bind(this));
true || this.clazz.bind(this);
return this.clazz.bind(this);

Comment on lines +143 to +146
parent.type === AST_NODE_TYPES.CallExpression &&
parent.callee.type === AST_NODE_TYPES.MemberExpression &&
parent.callee.property.type === AST_NODE_TYPES.Identifier &&
parent.callee.property.name === 'bind'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a strong enough check.
I.e. it will false positive in these cases, which are clearly improperly bound:

this.handleSomething.bind();
this.handleSomething.bind(null);
this.handleSomething.bind(undefined);

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Nov 12, 2019
@bradzacher bradzacher added enhancement New feature or request and removed bug Something isn't working labels Jan 10, 2020
@bradzacher bradzacher changed the title fix(eslint-plugin): fix unbound method triggering on class method bind feat(eslint-plugin): [unbound-method] support constructor binding Jan 10, 2020
@bradzacher bradzacher added the stale PRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period label Apr 13, 2020
@bradzacher bradzacher closed this Apr 13, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting response Issues waiting for a reply from the OP or another party enhancement New feature or request stale PRs or Issues that are at risk of being or have been closed due to inactivity for a prolonged period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[unbound-method] support binding methods inside constructor
2 participants