Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(eslint-plugin): Migrate plugin to ts #120

Merged
merged 97 commits into from Feb 11, 2019
Merged

feat(eslint-plugin): Migrate plugin to ts #120

merged 97 commits into from Feb 11, 2019

Commits on Jan 21, 2019

  1. rename files and start migration

    @bradzacher
    bradzacher committed Jan 21, 2019
    Copy the full SHA
    37dd878 View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2019

  1. start converting rules

    @bradzacher
    bradzacher committed Jan 22, 2019
    Copy the full SHA
    c651723 View commit details
    Browse the repository at this point in the history

  2. first pass type conversion done

    @bradzacher
    bradzacher committed Jan 22, 2019
    Copy the full SHA
    1714d3b View commit details
    Browse the repository at this point in the history

  3. es6 exports

    @bradzacher
    bradzacher committed Jan 22, 2019
    Copy the full SHA
    bcb3288 View commit details
    Browse the repository at this point in the history

  4. correct tooling paths

    @bradzacher
    bradzacher committed Jan 22, 2019
    Copy the full SHA
    5e68332 View commit details
    Browse the repository at this point in the history

  5. fix update-recommended script

    @bradzacher
    bradzacher committed Jan 22, 2019
    Copy the full SHA
    bbc841a View commit details
    Browse the repository at this point in the history

  6. add missing manual module typing files

    @bradzacher
    bradzacher committed Jan 22, 2019
    Copy the full SHA
    0d3e8ff View commit details
    Browse the repository at this point in the history

  7. address some review comments

    @bradzacher
    bradzacher committed Jan 22, 2019
    Copy the full SHA
    d4254f5 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2019

  1. Merge master into migrate-plugin-to-ts 

    # Conflicts:
#	packages/eslint-plugin/lib/util.js
#	packages/eslint-plugin/src/lib/rules/no-object-literal-type-assertion.ts
    @bradzacher
    bradzacher committed Jan 24, 2019
    Copy the full SHA
    ee56d42 View commit details
    Browse the repository at this point in the history

  2. convert tests to TS, move folders, fix bugs

    @bradzacher
    bradzacher committed Jan 24, 2019
    Copy the full SHA
    e44fba5 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2019

  1. started adding type defs for TSEstree

    @bradzacher
    bradzacher committed Jan 25, 2019
    Copy the full SHA
    fd3fc9d View commit details
    Browse the repository at this point in the history

  2. more types

    @bradzacher
    bradzacher committed Jan 25, 2019
    Copy the full SHA
    9bfbb86 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2019

  1. chore(ts-estree): draft of estree structure (replacement for ESTreeNo… 

    …de) (#137)
    @armano2 @bradzacher
    armano2 authored and bradzacher committed Jan 26, 2019
    Copy the full SHA
    a47e536 View commit details
    Browse the repository at this point in the history

  2. more types

    @bradzacher
    bradzacher committed Jan 26, 2019
    Copy the full SHA
    1e78ac5 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2019

  1. Finished adding types

    @bradzacher
    bradzacher committed Jan 30, 2019
    Copy the full SHA
    f5d15fa View commit details
    Browse the repository at this point in the history

  2. Filled out unions

    @bradzacher
    bradzacher committed Jan 30, 2019
    Copy the full SHA
    26e7275 View commit details
    Browse the repository at this point in the history

  3. removed types auto generated by armano

    @bradzacher
    bradzacher committed Jan 30, 2019
    Copy the full SHA
    1df6084 View commit details
    Browse the repository at this point in the history

  4. Fix some incorrect typings

    @bradzacher
    bradzacher committed Jan 30, 2019
    Copy the full SHA
    25579ad View commit details
    Browse the repository at this point in the history

  5. start strictly typing rules

    @bradzacher
    bradzacher committed Jan 30, 2019
    Copy the full SHA
    6d71be4 View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2019

  1. fix incorrect type for TSTypeRef

    @bradzacher
    bradzacher committed Jan 31, 2019
    Copy the full SHA
    a690933 View commit details
    Browse the repository at this point in the history

  2. find+replace remove create(context: Rule.RuleContext)

    @bradzacher
    bradzacher committed Jan 31, 2019
    Copy the full SHA
    9796d0f View commit details
    Browse the repository at this point in the history

  3. Bring SourceCode type internally

    @bradzacher
    bradzacher committed Jan 31, 2019
    Copy the full SHA
    4f8a9d1 View commit details
    Browse the repository at this point in the history

  4. adjacent-overload-signatures

    @bradzacher
    bradzacher committed Jan 31, 2019
    Copy the full SHA
    b76a2d7 View commit details
    Browse the repository at this point in the history

  5. array-type

    @bradzacher
    bradzacher committed Jan 31, 2019
    Copy the full SHA
    5826ca2 View commit details
    Browse the repository at this point in the history

  6. ban-types

    @bradzacher
    bradzacher committed Jan 31, 2019
    Copy the full SHA
    e18ad83 View commit details
    Browse the repository at this point in the history

  7. move the eslint retyping to a fake module

    @bradzacher
    bradzacher committed Jan 31, 2019
    Copy the full SHA
    c5875f6 View commit details
    Browse the repository at this point in the history

  8. add back tests accidentally deleted from adjacent-overload-sigs

    @bradzacher
    bradzacher committed Jan 31, 2019
    Copy the full SHA
    8f2e7e5 View commit details
    Browse the repository at this point in the history

  9. camelcase

    @bradzacher
    bradzacher committed Jan 31, 2019
    Copy the full SHA
    b08b70a View commit details
    Browse the repository at this point in the history

  10. tweak generics to be stricter and more ergonomic

    @bradzacher
    bradzacher committed Jan 31, 2019
    Copy the full SHA
    6f33e82 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2019

  1. rename test files and retype RuleTester

    @bradzacher
    bradzacher committed Feb 1, 2019
    Copy the full SHA
    99f14a1 View commit details
    Browse the repository at this point in the history

  2. class-name-casing

    @bradzacher
    bradzacher committed Feb 1, 2019
    Copy the full SHA
    e8fc817 View commit details
    Browse the repository at this point in the history

  3. explicit-function-return-type

    @bradzacher
    bradzacher committed Feb 1, 2019
    Copy the full SHA
    1ab295c View commit details
    Browse the repository at this point in the history

  4. explicit-member-accessibility

    @bradzacher
    bradzacher committed Feb 1, 2019
    Copy the full SHA
    35ab1bb View commit details
    Browse the repository at this point in the history

  5. generic-type-naming

    @bradzacher
    bradzacher committed Feb 1, 2019
    Copy the full SHA
    64ca20b View commit details
    Browse the repository at this point in the history

  6. indent 

    THIS ONE REALLY SUCKED
    @bradzacher
    bradzacher committed Feb 1, 2019
    Copy the full SHA
    14c0568 View commit details
    Browse the repository at this point in the history

  7. add comment to ts-estree types

    @bradzacher
    bradzacher committed Feb 1, 2019
    Copy the full SHA
    0f9b863 View commit details
    Browse the repository at this point in the history

  8. switch from npmignore to package.json files

    @bradzacher
    bradzacher committed Feb 1, 2019
    Copy the full SHA
    f35c261 View commit details
    Browse the repository at this point in the history

  9. interface-name-prefix

    @bradzacher
    bradzacher committed Feb 1, 2019
    Copy the full SHA
    c49d7e8 View commit details
    Browse the repository at this point in the history

  10. Switch to export default rules because it's nicer from a typescript s… 

    …tandpoint
    @bradzacher
    bradzacher committed Feb 1, 2019
    Copy the full SHA
    334c9b9 View commit details
    Browse the repository at this point in the history

  11. fix config so the test files get the proper types from src

    @bradzacher
    bradzacher committed Feb 1, 2019
    Copy the full SHA
    67c2ded View commit details
    Browse the repository at this point in the history

  12. member-delimiter-style

    @bradzacher
    bradzacher committed Feb 1, 2019
    Copy the full SHA
    9eb59cb View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2019

  1. revert typescript version bump

    @bradzacher
    bradzacher committed Feb 2, 2019
    Copy the full SHA
    393204f View commit details
    Browse the repository at this point in the history

  2. review fixes 1/n

    @bradzacher
    bradzacher committed Feb 2, 2019
    Copy the full SHA
    7ce246f View commit details
    Browse the repository at this point in the history

  3. review fixes 2/2

    @bradzacher
    bradzacher committed Feb 2, 2019
    Copy the full SHA
    f991152 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2019

  1. member-naming

    @bradzacher
    bradzacher committed Feb 4, 2019
    Copy the full SHA
    db338a3 View commit details
    Browse the repository at this point in the history

  2. member-ordering

    @bradzacher
    bradzacher committed Feb 4, 2019
    Copy the full SHA
    be34387 View commit details
    Browse the repository at this point in the history

  3. review fixes

    @bradzacher
    bradzacher committed Feb 4, 2019
    Copy the full SHA
    5d1165e View commit details
    Browse the repository at this point in the history

  4. no-angle-bracket-type-assertion

    @bradzacher
    bradzacher committed Feb 4, 2019
    Copy the full SHA
    6ef013a View commit details
    Browse the repository at this point in the history

  5. no-array-constructor

    @bradzacher
    bradzacher committed Feb 4, 2019
    Copy the full SHA
    8309b5d View commit details
    Browse the repository at this point in the history

  6. no-empty-interface

    @bradzacher
    bradzacher committed Feb 4, 2019
    Copy the full SHA
    4252c4a View commit details
    Browse the repository at this point in the history

  7. no-explicit-any

    @bradzacher
    bradzacher committed Feb 4, 2019
    Copy the full SHA
    efb0e9b View commit details
    Browse the repository at this point in the history

  8. no-extraneous-class

    @bradzacher
    bradzacher committed Feb 4, 2019
    Copy the full SHA
    22ab757 View commit details
    Browse the repository at this point in the history

  9. no-inferrable-types

    @bradzacher
    bradzacher committed Feb 4, 2019
    Copy the full SHA
    5ef1e40 View commit details
    Browse the repository at this point in the history

  10. no-misused-new

    @bradzacher
    bradzacher committed Feb 4, 2019
    Copy the full SHA
    616e3a5 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2019

  1. Merge master into migrate-plugin-to-ts

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    cbd7396 View commit details
    Browse the repository at this point in the history

  2. fix new tests + debug config

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    7f36b4b View commit details
    Browse the repository at this point in the history

  3. no-namespace

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    2a7fc49 View commit details
    Browse the repository at this point in the history

  4. add types for the eslint modules used in eslint-rules tests

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    3ae13c6 View commit details
    Browse the repository at this point in the history

  5. no-non-null-assertion

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    90c9dde View commit details
    Browse the repository at this point in the history

  6. no-object-literal-type-assertion

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    5c95e0e View commit details
    Browse the repository at this point in the history

  7. no-parameter-properties

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    3a8599c View commit details
    Browse the repository at this point in the history

  8. no-this-alias

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    0f4253a View commit details
    Browse the repository at this point in the history

  9. no-triple-slash-reference

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    48cb5a1 View commit details
    Browse the repository at this point in the history

  10. no-type-alias

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    077994a View commit details
    Browse the repository at this point in the history

  11. no-unused-vars

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    0634149 View commit details
    Browse the repository at this point in the history

  12. no-use-before-define

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    0d3b2b8 View commit details
    Browse the repository at this point in the history

  13. no-useless-constructor

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    d24d61d View commit details
    Browse the repository at this point in the history

  14. no-var-requires

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    ecc9582 View commit details
    Browse the repository at this point in the history

  15. prefer-interface

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    55542a2 View commit details
    Browse the repository at this point in the history

  16. prefer-namespace-keyword

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    4e0136d View commit details
    Browse the repository at this point in the history

  17. restrict-plus-operands

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    50dda72 View commit details
    Browse the repository at this point in the history

  18. type-annotation-spacing

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    f6527dd View commit details
    Browse the repository at this point in the history

  19. fixed up tests and build

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    49feb83 View commit details
    Browse the repository at this point in the history

  20. fix build error

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    6ec6b5f View commit details
    Browse the repository at this point in the history

  21. add typecheck command and fix errors

    @bradzacher
    bradzacher committed Feb 5, 2019
    Copy the full SHA
    bf31055 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2019

  1. move tsestree-utils into utils

    @bradzacher
    bradzacher committed Feb 6, 2019
    Copy the full SHA
    a294ea9 View commit details
    Browse the repository at this point in the history

  2. split utils into separate files to reduce overall file size

    @bradzacher
    bradzacher committed Feb 6, 2019
    Copy the full SHA
    a49264c View commit details
    Browse the repository at this point in the history

  3. add a createRule helper function 

    makes the rule creation process more ergonomic and gives us more control
    @bradzacher
    bradzacher committed Feb 6, 2019
    Copy the full SHA
    46dd1e5 View commit details
    Browse the repository at this point in the history

  4. remove a number of inconsistent/useless comments

    @bradzacher
    bradzacher committed Feb 6, 2019
    Copy the full SHA
    265a6c1 View commit details
    Browse the repository at this point in the history

  5. move parser ambient typings to fix the build

    @bradzacher
    bradzacher committed Feb 6, 2019
    Copy the full SHA
    419ccde View commit details
    Browse the repository at this point in the history

  6. Fix up some raw strings instead of enum usage

    @bradzacher
    bradzacher committed Feb 6, 2019
    Copy the full SHA
    0ac7c7f View commit details
    Browse the repository at this point in the history

  7. ran yarn format

    @bradzacher
    bradzacher committed Feb 6, 2019
    Copy the full SHA
    46613cc View commit details
    Browse the repository at this point in the history

  8. remove temporary isolated modules in tests

    @bradzacher
    bradzacher committed Feb 6, 2019
    Copy the full SHA
    ca20023 View commit details
    Browse the repository at this point in the history

  9. Merge branch 'master' into migrate-plugin-to-ts

    @bradzacher
    bradzacher committed Feb 6, 2019
    Copy the full SHA
    27c6eba View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2019

  1. review fixes

    @bradzacher
    bradzacher committed Feb 7, 2019
    Copy the full SHA
    ed6ed5e View commit details
    Browse the repository at this point in the history

  2. disable most eslint-plugin-eslint-plugin rules as they no longer are … 

    …needed
    @bradzacher
    bradzacher committed Feb 7, 2019
    Copy the full SHA
    ca5836e View commit details
    Browse the repository at this point in the history

  3. duplicated logic in no-extraneous-class

    @bradzacher
    bradzacher committed Feb 7, 2019
    Copy the full SHA
    79fe2b7 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into migrate-plugin-to-ts 

    # Conflicts:
#	packages/eslint-plugin/lib/rules/adjacent-overload-signatures.js
#	packages/eslint-plugin/lib/util.js
#	packages/eslint-plugin/package.json
#	packages/parser/src/eslint-scope.d.ts
#	packages/parser/src/parser.ts
#	packages/parser/src/typings.d.ts
#	packages/parser/typings/eslint-scope.d.ts
#	packages/typescript-estree/package.json
#	packages/typescript-estree/src/node-utils.ts
#	packages/typescript-estree/src/parser.ts
    @bradzacher
    bradzacher committed Feb 7, 2019
    Copy the full SHA
    7d3fac0 View commit details
    Browse the repository at this point in the history

  5. fix types on promise-function-async

    @bradzacher
    bradzacher committed Feb 7, 2019
    Copy the full SHA
    5f6c1ed View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2019

  1. Merge branch 'master' into migrate-plugin-to-ts 

    # Conflicts:
#	packages/eslint-plugin/lib/rules/no-unnecessary-type-assertion.js
    @bradzacher
    bradzacher committed Feb 9, 2019
    Copy the full SHA
    4158deb View commit details
    Browse the repository at this point in the history

  2. rename the base tsconfig file to prevent errors in visual studio (not… 

    … code)
    @bradzacher
    bradzacher committed Feb 9, 2019
    Copy the full SHA
    2f6ff83 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2019

  1. fix build

    @bradzacher
    bradzacher committed Feb 10, 2019
    Copy the full SHA
    917a9f1 View commit details
    Browse the repository at this point in the history

  2. review

    @bradzacher
    bradzacher committed Feb 10, 2019
    Copy the full SHA
    cb359d3 View commit details
    Browse the repository at this point in the history

  3. switch RuleTester to a non-default export

    @bradzacher
    bradzacher committed Feb 10, 2019
    Copy the full SHA
    c652486 View commit details
    Browse the repository at this point in the history

  4. review fixes pt 1

    @bradzacher
    bradzacher committed Feb 10, 2019
    Copy the full SHA
    51c7635 View commit details
    Browse the repository at this point in the history

  5. add removed type checks back into tests

    @bradzacher
    bradzacher committed Feb 10, 2019
    Copy the full SHA
    5c8ad1a View commit details
    Browse the repository at this point in the history

  6. barrel up ts-estree

    @bradzacher
    bradzacher committed Feb 10, 2019
    Copy the full SHA
    3384ed1 View commit details
    Browse the repository at this point in the history