Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [req-await] crash on nonasync promise return #1228

Merged
merged 1 commit into from
Nov 19, 2019

Conversation

bradzacher
Copy link
Member

Fixes #1226

There wasn't a test case for a non-async function that returned a promise.

@bradzacher bradzacher added the bug Something isn't working label Nov 19, 2019
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 19, 2019

Codecov Report

Merging #1228 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1228      +/-   ##
==========================================
- Coverage   94.23%   94.23%   -0.01%     
==========================================
  Files         126      126              
  Lines        5376     5375       -1     
  Branches     1509     1509              
==========================================
- Hits         5066     5065       -1     
  Misses        177      177              
  Partials      133      133
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/require-await.ts 100% <100%> (ø) ⬆️

@bradzacher bradzacher changed the title fix(eslint-plugin): [require-await] crash on non-async returning promise fix(eslint-plugin): [req-await] crash on nonasync promise return Nov 19, 2019
@bradzacher bradzacher merged commit 56c00b3 into master Nov 19, 2019
@bradzacher bradzacher deleted the 1226-require-await-non-async-promise branch November 19, 2019 17:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[require-await] Cannot set property 'hasAwait' of null in file
1 participant