Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): add extension [no-dupe-class-members] #1492

Merged
merged 2 commits into from Feb 2, 2020

Conversation

bradzacher
Copy link
Member

Fixes #291

@bradzacher bradzacher added the enhancement: new base rule extension New base rule extension required to handle a TS specific case label Jan 22, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Feb 2, 2020

Codecov Report

Merging #1492 into master will decrease coverage by 0.08%.
The diff coverage is 92.51%.

@@            Coverage Diff            @@
##           master   #1492      +/-   ##
=========================================
- Coverage   95.59%   95.5%   -0.09%     
=========================================
  Files         148     141       -7     
  Lines        6628    6409     -219     
  Branches     1893    1832      -61     
=========================================
- Hits         6336    6121     -215     
+ Misses        111     105       -6     
- Partials      181     183       +2
Impacted Files Coverage Δ
...nt-plugin/src/rules/indent-new-do-not-use/index.ts 98.4% <ø> (ø) ⬆️
...s/eslint-plugin/src/rules/interface-name-prefix.ts 100% <ø> (+16.66%) ⬆️
...nt-plugin/src/rules/no-unused-vars-experimental.ts 91.39% <ø> (ø) ⬆️
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 93.1% <ø> (ø) ⬆️
...ges/experimental-utils/src/ts-eslint/SourceCode.ts 100% <ø> (ø) ⬆️
packages/eslint-plugin/src/rules/no-type-alias.ts 100% <ø> (ø) ⬆️
...nt-plugin/src/rules/no-extra-non-null-assertion.ts 100% <100%> (ø) ⬆️
.../eslint-plugin/src/rules/triple-slash-reference.ts 96.66% <100%> (+0.11%) ⬆️
packages/typescript-estree/src/convert-comments.ts 100% <100%> (ø) ⬆️
...-plugin/src/rules/explicit-function-return-type.ts 100% <100%> (ø) ⬆️
... and 32 more

@bradzacher bradzacher merged commit b22424e into master Feb 2, 2020
@bradzacher bradzacher deleted the no-dupe-class-members branch February 2, 2020 17:33
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: new base rule extension New base rule extension required to handle a TS specific case
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-dupe-class-members] false negative for method overload
1 participant