Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add funding field to package.json #1499

Merged
merged 4 commits into from
Jan 23, 2020
Merged

chore: add funding field to package.json #1499

merged 4 commits into from
Jan 23, 2020

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Jan 23, 2020

This PR removes opencollective-postinstall that was used only during dev build and adds a funding field to the package.json so users installing will know how to contribute.

This is a new feature as of npm version 6.13.

See:

@typescript-eslint

This comment has been minimized.

@armano2 armano2 added the dependencies Issue about dependencies of the package label Jan 23, 2020
package.json Outdated Show resolved Hide resolved
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably also want to add it to every single one of our packages.

@armano2

This comment has been minimized.

@armano2
Copy link
Member Author

armano2 commented Jan 23, 2020

probably also want to add it to every single one of our packages.

i added it to all public packages except tslint as this is only wrapper

@codecov
Copy link

codecov bot commented Jan 23, 2020

Codecov Report

Merging #1499 into master will decrease coverage by 0.01%.
The diff coverage is 94%.

@@            Coverage Diff             @@
##           master    #1499      +/-   ##
==========================================
- Coverage   95.58%   95.57%   -0.02%     
==========================================
  Files         147      148       +1     
  Lines        6616     6666      +50     
  Branches     1891     1910      +19     
==========================================
+ Hits         6324     6371      +47     
- Misses        111      112       +1     
- Partials      181      183       +2
Impacted Files Coverage Δ
packages/eslint-plugin/src/util/astUtils.ts 87.5% <ø> (ø) ⬆️
packages/eslint-plugin/src/rules/index.ts 100% <100%> (ø) ⬆️
packages/eslint-plugin/src/rules/comma-spacing.ts 93.87% <93.87%> (ø)

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@bradzacher bradzacher merged commit 56acddd into typescript-eslint:master Jan 23, 2020
@armano2 armano2 deleted the opencollective branch January 23, 2020 20:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants