Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(eslint-plugin): add script to generate the readme tables #1524

Merged
merged 3 commits into from
Jan 27, 2020
Merged

docs(eslint-plugin): add script to generate the readme tables #1524

merged 3 commits into from
Jan 27, 2020

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jan 25, 2020

I created a new branch b/c it was easier than trying to rebase my existing branch.

Closes #1435

@typescript-eslint

This comment has been minimized.

Sign in to view
@G-Rath G-Rath requested review from bradzacher and armano2 and removed request for bradzacher January 25, 2020 21:14
@armano2 armano2 added documentation Documentation ("docs") that needs adding/updating package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin labels Jan 25, 2020
@G-Rath
Copy link
Contributor Author

G-Rath commented Jan 25, 2020

Cannot find module './lint-output.json' from 'test.js'

That's an interesting integration test failure that I'm pretty sure I didn't cause?

@armano2
Copy link
Member

armano2 commented Jan 25, 2020

i restarted build, for unknown reason in integration tests there was no typescript installed

bradzacher
bradzacher approved these changes Jan 26, 2020
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks so much for doing this.

packages/eslint-plugin/tools/generate-rules-lists.ts Show resolved Hide resolved
@bradzacher bradzacher changed the title Create table generating script chore(eslint-plugin): add script to generate the readme tables Jan 26, 2020
@bradzacher bradzacher changed the title chore(eslint-plugin): add script to generate the readme tables docs(eslint-plugin): add script to generate the readme tables Jan 26, 2020
@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #1524 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1524      +/-   ##
==========================================
+ Coverage   95.57%   95.57%   +<.01%     
==========================================
  Files         149      149              
  Lines        6688     6691       +3     
  Branches     1915     1917       +2     
==========================================
+ Hits         6392     6395       +3     
  Misses        112      112              
  Partials      184      184
Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 99.43% <100%> (ø) ⬆️

@bradzacher bradzacher mentioned this pull request Jan 27, 2020
Closed
@bradzacher bradzacher merged commit 367b18f into typescript-eslint:master Jan 27, 2020
@G-Rath G-Rath deleted the create-table-generating-script branch January 27, 2020 00:07
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@armano2 armano2 armano2 left review comments

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
documentation Documentation ("docs") that needs adding/updating package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@G-Rath @armano2 @bradzacher