Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix coverage reports from codecov #1528

Merged
merged 2 commits into from Jan 26, 2020

Conversation

@armano2
Copy link
Member

armano2 commented Jan 26, 2020

Bash uploader used for sending coverage reports to codecov currently is broken for azure pipelines.

This fixes missing pr in query sent to codecov by providing it as parameter

Codecov bash script https://codecov.io/bash

-P pr
Specify the pull request number

Pipelines docs https://docs.microsoft.com/en-us/azure/devops/pipelines/build/variables?view=azure-devops&tabs=yaml

System.PullRequest.PullRequestNumber
The number of the pull request that caused this build. This variable is populated for pull requests from GitHub which have a different pull request ID and pull request number.


Codecov link

https://codecov.io/gh/typescript-eslint/typescript-eslint/pull/1528/commits

Pipelines action

https://dev.azure.com/typescript-eslint/TypeScript%20ESLint/_build/results?buildId=3139&view=logs&jobId=18ce2c0c-8e5f-561b-2a1a-c5027ed6632f&j=18ce2c0c-8e5f-561b-2a1a-c5027ed6632f&t=477fddef-3d25-5c61-8626-53dac583e4f5

pr=1528

query: branch=merge&commit=23be3107029912cf459f3b3cb9de1bdb768d7a9b&build=20200126.2&build_url=https%3A%2F%2Fdev.azure.com%2Ftypescript-eslint%2FTypeScript%20ESLint%2F_build%2Fresults%3FbuildId%3D3139&name=&tag=&slug=typescript-eslint%2Ftypescript-eslint&service=azure_pipelines&flags=&pr=1528&job=3139&project=TypeScriptESLint&server_uri=https://dev.azure.com/typescript-eslint/

codecov/codecov-bash#189

@typescript-eslint

This comment was marked as resolved.

Copy link

typescript-eslint bot commented Jan 26, 2020

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@armano2 armano2 self-assigned this Jan 26, 2020
@armano2 armano2 added bug tests labels Jan 26, 2020
@armano2 armano2 changed the title test: attempt to fix coverage reports from codecov test: fix coverage reports from codecov Jan 26, 2020
@armano2 armano2 marked this pull request as ready for review Jan 26, 2020
@armano2 armano2 requested a review from bradzacher Jan 26, 2020
@bradzacher bradzacher merged commit 6d1d2a2 into typescript-eslint:master Jan 26, 2020
7 checks passed
7 checks passed
Semantic Pull Request ready to be squashed
Details
codecov/patch Coverage not affected when comparing 67784d6...5c62521
Details
codecov/project 95.57% remains the same compared to 67784d6
Details
typescript-eslint.typescript-eslint Build #20200126.2 succeeded
Details
typescript-eslint.typescript-eslint (Primary code validation and tests) Primary code validation and tests succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_10_x) Run unit tests on other Node.js versions node_10_x succeeded
Details
typescript-eslint.typescript-eslint (Run unit tests on other Node.js versions node_8_x) Run unit tests on other Node.js versions node_8_x succeeded
Details
@armano2 armano2 deleted the armano2:codecov-fix branch Jan 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.