Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): Draft of scope analysis with types #1533

Closed
wants to merge 12 commits into from
Closed

feat(parser): Draft of scope analysis with types #1533

wants to merge 12 commits into from

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Jan 28, 2020

Unfinished and not fully working scope analysis for types.
Original work was started some time ago in #233 and this PR contains all changes rebased to current master

some of changes got migrated outside of this PR to master already and are dropped from here


This is early stage of updated scope-analysis with types included into scope, there is still a lot to do.
Goal of this PR is to solve #18, #19, #21, #60, #207 #122, #249, #342, #1542

@armano2 armano2 added DO NOT MERGE PRs which should not be merged yet scope analyser Issues that are caused by bugs/incomplete cases in the scope analyser labels Jan 28, 2020
@typescript-eslint

This comment has been minimized.

@bradzacher
Copy link
Member

bradzacher commented Jan 29, 2020

I've never liked this custom scope analyser, because it is a lot of code for us to maintain, and being built on the (poorly documented) eslint-scope really limits its maintenance to... well you.

Does typescript expose any of its scope analysis data? If yes, would it be better to do a conversion pass over this data instead?

Having a quick look, it looks like TS has checker.getSymbolsInScope(node, SymbolFlags): Symbols[], can we use this?

@bradzacher
Copy link
Member

Closing this in favour of #1939

@bradzacher bradzacher closed this May 14, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 14, 2020
@armano2 armano2 deleted the typed-scopes-v3 branch February 13, 2021 15:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
DO NOT MERGE PRs which should not be merged yet scope analyser Issues that are caused by bugs/incomplete cases in the scope analyser
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants