Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): export * regression from 133f622f #1751

merged 2 commits into from Mar 18, 2020


Copy link

@bradzacher bradzacher commented Mar 17, 2020

Fixes #1746

133f622 / #1698 introduced a regression.
This was a case I didn't think about in the original implementation.
It's a hole in the types due to the fact that the SyntaxKind enum member, ofc always exists in 3.8.x.

Tested this via:

  • change the resolved typescript version in the root package.json to 3.7.5
  • yarn lint - no parsing errors

@bradzacher bradzacher added the bug Something isn't working label Mar 17, 2020
Copy link

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #1751 into master will not change coverage by %.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1751   +/-   ##
  Coverage   95.19%   95.19%           
  Files         148      148           
  Lines        6968     6968           
  Branches     2009     2009           
  Hits         6633     6633           
  Misses        124      124           
  Partials      211      211           
Flag Coverage Δ
#unittest 95.19% <100.00%> (ø)
Impacted Files Coverage Δ
packages/typescript-estree/src/convert.ts 99.15% <100.00%> (ø)

@bradzacher bradzacher added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

Regression in 2.24.0: TypeError: Cannot read property 'name' of undefined
2 participants