Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): fix message of no-base-to-string #1755



Copy link

@susisu susisu commented Mar 17, 2020

({}).toString() === "[object Object]"

Copy link

Thanks for the PR, @susisu!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the 1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready label Mar 17, 2020
Copy link

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

@bradzacher bradzacher added the bug Something isn't working label Mar 17, 2020
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #1755 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1755   +/-   ##
  Coverage   95.19%   95.19%           
  Files         148      148           
  Lines        6971     6971           
  Branches     2010     2010           
  Hits         6636     6636           
  Misses        124      124           
  Partials      211      211           
Flag Coverage Δ
#unittest 95.19% <ø> (ø)
Impacted Files Coverage Δ
...kages/eslint-plugin/src/rules/no-base-to-string.ts 100.00% <ø> (ø)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 approval PR that a maintainer has LGTM'd - any maintainer can merge this when ready bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants