Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [quotes] false positive with backtick in import equals statement #1769

merged 1 commit into from Mar 19, 2020


Copy link

@regevbr regevbr commented Mar 19, 2020

Fixes #1766

Copy link

Thanks for the PR, @regevbr!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the bug Something isn't working label Mar 19, 2020
Copy link

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #1769 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1769   +/-   ##
  Coverage   95.19%   95.19%           
  Files         148      148           
  Lines        6971     6971           
  Branches     2010     2010           
  Hits         6636     6636           
  Misses        124      124           
  Partials      211      211           
Flag Coverage Δ
#unittest 95.19% <ø> (ø)
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/quotes.ts 94.11% <ø> (ø)

@bradzacher bradzacher changed the title fix(eslint-plugin): #1766 False positive with backtick in require lines fix(eslint-plugin): [quotes] false positive with backtick in import equals statement Mar 19, 2020
@bradzacher bradzacher merged commit 199863d into typescript-eslint:master Mar 19, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
bug Something isn't working
None yet

Successfully merging this pull request may close these issues.

[quotes] False positive with backtick in require lines
2 participants