Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(eslint-plugin): [prefer-readonly-parameter-types] fix invalid example #1791

Merged
merged 1 commit into from Mar 23, 2020

Conversation

bradzacher
Copy link
Member

Fixes #1789

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Mar 23, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Mar 23, 2020

Codecov Report

Merging #1791 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1791   +/-   ##
=======================================
  Coverage   95.02%   95.02%           
=======================================
  Files         159      159           
  Lines        7112     7112           
  Branches     2033     2033           
=======================================
  Hits         6758     6758           
  Misses        154      154           
  Partials      200      200           
Flag Coverage Δ
#unittest 95.02% <ø> (ø)

@bradzacher bradzacher merged commit b1b8284 into master Mar 23, 2020
@bradzacher bradzacher deleted the prefer-readonly-parameter-types-patch-1 branch March 23, 2020 23:06
ulrichb added a commit to ulrichb/typescript-eslint that referenced this pull request Mar 26, 2020
ulrichb added a commit to ulrichb/typescript-eslint that referenced this pull request Mar 26, 2020
ulrichb added a commit to ulrichb/typescript-eslint that referenced this pull request Mar 26, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[prefer-readonly-parameter-types] extending ReadonlyArray gives false positive
1 participant