feat(eslint-plugin): added allowSuper option for unbound-method

[anikethsaha]

fixes #1866

Added options

allowSuper : default : false - type : boolean

should it be false by default ? let me know

[typescript-eslint]

Thanks for the PR, @anikethsaha!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

---

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

[bradzacher]

Code mostly LGTM

Could you please drop the option?
I don't think this needs an option - it should just be part of how the rule works.

[bradzacher]

This is unsafe - prefer an explicit check.

Suggested change

	(node as TSESTree.MemberExpression) &&
	node.type === AST_NODE_TYPES.MemberExpression &&

[bradzacher]

can you please add a sanity check, this should report an error

class BaseClass {
  x: number = 42;
  logThis() {
    console.log('x is ');
  }
}
class OtherClass extends BaseClass {
  superLogThis: any;
  constructor() {
    super();
    const x = super.logThis; // ERROR - unbound method
  }
}