Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(typescript-estree): separate snapshots for ast tests #2290

Merged
merged 1 commit into from
Jul 17, 2020

Conversation

bradzacher
Copy link
Member

Closes #1491
Fixes #1142

Following in the steps of what I did for scope manager and the exploratory work we've done in the past, this uses jest-specific-snapshot to create a snapshot per fixture instead of a mega snapshot.

This should make it easier to review AST changes and should be easier to inspect and maintain.

@bradzacher bradzacher added the tests anything to do with testing label Jul 13, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #2290 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2290      +/-   ##
==========================================
- Coverage   93.12%   93.11%   -0.02%     
==========================================
  Files         283      283              
  Lines        9057     9057              
  Branches     2482     2482              
==========================================
- Hits         8434     8433       -1     
  Misses        301      301              
- Partials      322      323       +1     
Flag Coverage Δ
#unittest 93.11% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ript-estree/src/create-program/createSourceFile.ts 87.50% <0.00%> (-12.50%) ⬇️

@bradzacher bradzacher changed the title tests(typescript-estree): separate snapshots for ast tests test(typescript-estree): separate snapshots for ast tests Jul 13, 2020
@bradzacher bradzacher marked this pull request as ready for review July 13, 2020 05:57
@bradzacher bradzacher merged commit 2eb3ca4 into master Jul 17, 2020
@bradzacher bradzacher deleted the separate-snapshots branch July 17, 2020 19:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests anything to do with testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor fixture tests so they don't generate a single giant snapshot file
1 participant