Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2279.
There are actually two functions from lodash being used today:
memoize
is, IMO, a nice little thing to have. Since it doesn't use regular expressions the way the parts of lodash that sometimes get CVEs do, I figured we could keep it.unescape
is the direct part of anunescapeStringLiteralText
that actually does fail unit tests when removed: https://github.com/typescript-eslint/typescript-eslint/pull/2517/checks?check_run_id=1083789433.IMO there's still benefit to the "lodash ideology" of using the same stable functions & high quality docs across projects -- and
unescape
is itself also pretty stable.