Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove lodash #2517

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Sep 8, 2020

Fixes #2279.

There are actually two functions from lodash being used today:

memoize is, IMO, a nice little thing to have. Since it doesn't use regular expressions the way the parts of lodash that sometimes get CVEs do, I figured we could keep it.

unescape is the direct part of an unescapeStringLiteralText that actually does fail unit tests when removed: https://github.com/typescript-eslint/typescript-eslint/pull/2517/checks?check_run_id=1083789433.

-  "value": "&",
+  "value": "&",

IMO there's still benefit to the "lodash ideology" of using the same stable functions & high quality docs across projects -- and unescape is itself also pretty stable.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: remove lodash.unescape; specify lodash.memoize chore: specified specific lodash libraries: memoize, unescape Sep 8, 2020
@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: specified specific lodash libraries: memoize, unescape chore: remove lodash Sep 8, 2020
@JoshuaKGoldberg
Copy link
Member Author

Hmm, I'm starting to have doubts about the benefits of removing lodash entirely. I'll post in the issue.

@JoshuaKGoldberg JoshuaKGoldberg deleted the lodash-specifics branch September 8, 2020 02:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove lodash?
1 participant