Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unused-vars] better handling for declared modules #2553

Merged
merged 1 commit into from Sep 13, 2020

Conversation

@bradzacher
Copy link
Member

@bradzacher bradzacher commented Sep 13, 2020

Fixes #2523

  • declare global should never be marked as unused.
  • namespaces within declared namespaces all ambiently export their children
…ules

Fixes #2523

- `declare global` should never be marked as unused.
- namespaces within declared namespaces all ambiently export their children
@bradzacher bradzacher added the bug label Sep 13, 2020
@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Sep 13, 2020

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

@codecov codecov bot commented Sep 13, 2020

Codecov Report

Merging #2553 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2553   +/-   ##
=======================================
  Coverage   92.81%   92.81%           
=======================================
  Files         290      290           
  Lines        9453     9456    +3     
  Branches     2647     2648    +1     
=======================================
+ Hits         8774     8777    +3     
  Misses        322      322           
  Partials      357      357           
Flag Coverage Δ
#unittest 92.81% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/no-unused-vars.ts 93.06% <ø> (+0.21%) ⬆️
@bradzacher bradzacher merged commit 02d72d4 into master Sep 13, 2020
10 checks passed
10 checks passed
Typecheck
Details
Unit tests Unit tests
Details
Code style and lint
Details
Run integration tests on primary Node.js version
Details
Run unit tests on other Node.js versions (10.x)
Details
Run unit tests on other Node.js versions (14.x)
Details
Publish the latest code as a canary version
Details
Semantic Pull Request ready to be squashed
Details
codecov/patch Codecov Report
Details
codecov/project Codecov Report
Details
@bradzacher bradzacher deleted the 2523-declared-modules-unused branch Sep 13, 2020
phaux added a commit to phaux/typescript-eslint that referenced this pull request Sep 28, 2020
…ules (typescript-eslint#2553)

Fixes typescript-eslint#2523

- `declare global` should never be marked as unused.
- namespaces within declared namespaces all ambiently export their children
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant