Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-invalid-this] allow "this" in class property definitions #2685



Copy link

@krisztianb krisztianb commented Oct 18, 2020

Fixes #491

This should fix the things mentioned in the issue. I also added some tests for the new cases.
It seemed almost too easy to fix, so please let me know if I'm missing anything.


Copy link

@typescript-eslint typescript-eslint bot commented Oct 18, 2020

Thanks for the PR, @krisztianb!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

@codecov codecov bot commented Oct 18, 2020

Codecov Report

Merging #2685 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #2685   +/-   ##
  Coverage   92.78%   92.78%           
  Files         294      294           
  Lines        9676     9678    +2     
  Branches     2713     2713           
+ Hits         8978     8980    +2     
  Misses        330      330           
  Partials      368      368           
Flag Coverage Δ
#unittest 92.78% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/no-invalid-this.ts 95.83% <100.00%> (+0.37%) ⬆️
Copy link

@bradzacher bradzacher left a comment

LGTM - thanks for fixing this!

@bradzacher bradzacher merged commit dccb6ee into typescript-eslint:master Oct 18, 2020
10 checks passed
10 checks passed
Unit tests Unit tests
Code style and lint
Run integration tests on primary Node.js version
Run unit tests on other Node.js versions (10.x)
Run unit tests on other Node.js versions (14.x)
Publish the latest code as a canary version
Semantic Pull Request ready to be squashed
codecov/patch 100.00% of diff hit (target 90.00%)
codecov/project 92.78% (+0.00%) compared to 90a5878
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.