Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: align class property with estree stage3 class-features #3077

Closed
wants to merge 4 commits into from

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Feb 19, 2021

Align ClassProperty and TSAbstractClassProperty nodes with estree

https://github.com/estree/estree/blob/c8d27a958d49cdd5255fd79b4e2f271ad0d8bff1/stage3/class-features.md

fixes #3068

@armano2 armano2 added breaking change This change will require a new major version to be released AST PRs and Issues about the AST structure labels Feb 19, 2021
@armano2 armano2 added this to the 5.0.0 milestone Feb 19, 2021
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @armano2!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #3077 (56c30dc) into v5 (763a252) will increase coverage by 0.00%.
The diff coverage is 83.33%.

@@           Coverage Diff           @@
##               v5    #3077   +/-   ##
=======================================
  Coverage   92.83%   92.83%           
=======================================
  Files         314      314           
  Lines       10675    10676    +1     
  Branches     3027     3027           
=======================================
+ Hits         9910     9911    +1     
  Misses        348      348           
  Partials      417      417           
Flag Coverage Δ
unittest 92.83% <83.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-plugin/src/rules/class-literal-property-style.ts 100.00% <ø> (ø)
...-plugin/src/rules/explicit-member-accessibility.ts 97.10% <ø> (ø)
...plugin/src/rules/explicit-module-boundary-types.ts 89.47% <ø> (ø)
...nt-plugin/src/rules/indent-new-do-not-use/index.ts 98.13% <ø> (ø)
packages/eslint-plugin/src/rules/indent.ts 90.47% <ø> (ø)
packages/eslint-plugin/src/rules/no-extra-semi.ts 100.00% <ø> (ø)
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 93.33% <ø> (ø)
...ackages/eslint-plugin/src/rules/no-invalid-this.ts 95.83% <ø> (ø)
...es/eslint-plugin/src/rules/no-invalid-void-type.ts 95.34% <ø> (ø)
...ckages/eslint-plugin/src/rules/no-magic-numbers.ts 80.76% <0.00%> (ø)
... and 13 more

@bradzacher bradzacher changed the base branch from master to v5 August 21, 2021 22:17
@bradzacher bradzacher marked this pull request as draft August 21, 2021 22:17
bradzacher added a commit that referenced this pull request Aug 28, 2021
bradzacher added a commit that referenced this pull request Aug 28, 2021
bradzacher added a commit that referenced this pull request Aug 28, 2021
@bradzacher
Copy link
Member

Closed in favour of #3806

@bradzacher bradzacher closed this Aug 28, 2021
@bradzacher bradzacher deleted the feat/class-property-proeprty-definition branch September 3, 2021 17:58
bradzacher added a commit that referenced this pull request Sep 3, 2021
bradzacher added a commit that referenced this pull request Sep 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2021
bradzacher added a commit that referenced this pull request Oct 10, 2021
bradzacher added a commit that referenced this pull request Oct 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AST PRs and Issues about the AST structure breaking change This change will require a new major version to be released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alignment with ESTree class-features
2 participants