Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(experimental-utils): fix isAwaitKeyword predicate #3290

merged 1 commit into from May 21, 2021


Copy link

@MichaelDeBoey MichaelDeBoey commented Apr 15, 2021

No description provided.

Copy link

@typescript-eslint typescript-eslint bot commented Apr 15, 2021

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.


@bradzacher bradzacher added the bug label Apr 15, 2021
packages/experimental-utils/src/ast-utils/predicates.ts Outdated Show resolved Hide resolved
Copy link

@codecov codecov bot commented May 19, 2021

Codecov Report

Merging #3290 (6892845) into master (6291f38) will increase coverage by 0.17%.
The diff coverage is n/a.

Current head 6892845 differs from pull request most recent head adae4aa. Consider uploading reports for the commit adae4aa to get more accurate results

@@            Coverage Diff             @@
##           master    #3290      +/-   ##
+ Coverage   92.68%   92.85%   +0.17%     
  Files         318      318              
  Lines       11100    11048      -52     
  Branches     3152     3128      -24     
- Hits        10288    10259      -29     
+ Misses        361      352       -9     
+ Partials      451      437      -14     
Flag Coverage Δ
unittest 92.85% <ø> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/experimental-utils/src/ast-utils/predicates.ts 36.84% <ø> (ø)
packages/eslint-plugin/src/rules/dot-notation.ts 84.21% <0.00%> (-8.39%) ⬇️
packages/eslint-plugin/src/util/types.ts 81.86% <0.00%> (-0.39%) ⬇️
...ckages/eslint-plugin/src/rules/no-unsafe-return.ts 98.24% <0.00%> (ø)
...ages/eslint-plugin/src/rules/no-unsafe-argument.ts 85.22% <0.00%> (ø) 92.96% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-shadow.ts 94.04% <0.00%> (+17.43%) ⬆️


Copy link

@bradzacher bradzacher left a comment



@bradzacher bradzacher merged commit c15da67 into typescript-eslint:master May 21, 2021
10 checks passed
@MichaelDeBoey MichaelDeBoey deleted the patch-3 branch May 21, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants