Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint-plugin): remove lodash from dependencies #3478

Merged

Conversation

SukkaW
Copy link
Contributor

@SukkaW SukkaW commented Jun 2, 2021

It is not necessary to add a full lodash as a dependency just for escaping RegExp, right?

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @SukkaW!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher linked an issue Jun 3, 2021 that may be closed by this pull request
@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Jun 3, 2021
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Jun 13, 2021
@SukkaW SukkaW force-pushed the eslint-plugin-remove-lodash branch from 38d3d4f to 80ac539 Compare June 13, 2021 06:59
@codecov
Copy link

codecov bot commented Jun 20, 2021

Codecov Report

Merging #3478 (80ac539) into master (fc5f171) will decrease coverage by 0.02%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #3478      +/-   ##
==========================================
- Coverage   92.66%   92.63%   -0.03%     
==========================================
  Files         324      326       +2     
  Lines       11188    11240      +52     
  Branches     3157     3170      +13     
==========================================
+ Hits        10367    10412      +45     
- Misses        365      368       +3     
- Partials      456      460       +4     
Flag Coverage Δ
unittest 92.63% <83.33%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/util/escapeRegExp.ts 80.00% <80.00%> (ø)
packages/eslint-plugin/src/util/astUtils.ts 81.81% <100.00%> (ø)
...ackages/eslint-plugin/src/rules/prefer-includes.ts 97.87% <0.00%> (-1.03%) ⬇️
...es/experimental-utils/src/ts-eslint-scope/index.ts 100.00% <0.00%> (ø)
...int-plugin/src/rules/prefer-literal-enum-member.ts 100.00% <0.00%> (ø)
...ils/src/ast-utils/eslint-utils/ReferenceTracker.ts 100.00% <0.00%> (ø)
...t-estree/src/create-program/useProvidedPrograms.ts 84.84% <0.00%> (ø)
packages/typescript-estree/src/convert.ts 98.27% <0.00%> (+<0.01%) ⬆️
...ckages/eslint-plugin/src/rules/no-unsafe-return.ts 98.30% <0.00%> (+0.05%) ⬆️
... and 2 more

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Jun 20, 2021
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit c50f70b into typescript-eslint:master Jun 20, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove lodash?
3 participants