Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-estree): add support for custom module resolution #3516

Merged
merged 3 commits into from Jul 31, 2021

Conversation

rdsedmundo
Copy link
Contributor

@rdsedmundo rdsedmundo commented Jun 12, 2021

Fixes #2771

See #3514 (comment) for context on why simply using the options.programs is not sufficient. tldr: when we pass a new program we have to re-implement a lot of what is already well done by the typescript-eslint team like caching and invalidating files properly.

I'm not too familiar with the codebase, but I did my best to follow the standards from the files I touched. The implementation is on the basis of this comment of @bradzacher.

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Jun 12, 2021

Thanks for the PR, @rdsedmundo!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher added the enhancement New feature or request label Jun 13, 2021
jondkoon
jondkoon previously approved these changes Jun 18, 2021
Copy link

@jondkoon jondkoon left a comment

Nice! 🚀

@codecov
Copy link

codecov bot commented Jun 18, 2021

Codecov Report

Merging #3516 (a0b73fa) into master (407a374) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3516   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files         326      326           
  Lines       11253    11263   +10     
  Branches     3171     3173    +2     
=======================================
+ Hits        10425    10435   +10     
  Misses        368      368           
  Partials      460      460           
Flag Coverage Δ
unittest 92.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-estree/src/create-program/createDefaultProgram.ts 78.26% <100.00%> (+2.07%) ⬆️
...pt-estree/src/create-program/createWatchProgram.ts 77.27% <100.00%> (+0.23%) ⬆️
...ges/typescript-estree/src/create-program/shared.ts 90.19% <100.00%> (+1.30%) ⬆️

@nx-cloud
Copy link

nx-cloud bot commented Jun 18, 2021

Nx Cloud Report

CI is running for commit a0b73fa.

📂 Click to track the progress, see the status, the terminal output, and the build insights.


Sent with 💌 from NxCloud.

@rdsedmundo
Copy link
Contributor Author

rdsedmundo commented Jul 6, 2021

@bradzacher I have improved the test coverage since the CI ran, can you allow it to run again? Thanks.

Copy link
Member

@bradzacher bradzacher left a comment

LGTM - thanks for your contribution!

@bradzacher bradzacher merged commit d48429d into typescript-eslint:master Jul 31, 2021
10 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants