Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript-eslint-parser): pass services generated by typescript-estree to consumer #37

Merged
merged 2 commits into from Jan 17, 2019

Conversation

uniqueiniquity
Copy link
Contributor

This PR picks up the changes made in JamesHenry/typescript-estree#24 and exposes them to consumers of this package. In particular, this will allow rules to reference the TS program created to parse the TS source, as well as provide maps between corresponding nodes in the TS and ESTree representations of the parsed ASTs.

@codecov
Copy link

codecov bot commented Jan 17, 2019

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   93.77%   93.77%           
=======================================
  Files          11       11           
  Lines        1686     1686           
  Branches      376      376           
=======================================
  Hits         1581     1581           
  Misses         55       55           
  Partials       50       50
Impacted Files Coverage Δ
packages/typescript-eslint-parser/src/parser.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe638b...6965773. Read the comment docs.

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @uniqueiniquity! We'll be cutting the first release from the monorepo next week, just FYI, we are coordinating things with the ESLint Team, as they prepare messaging on their side

@JamesHenry JamesHenry merged commit 66b586d into typescript-eslint:master Jan 17, 2019
@uniqueiniquity uniqueiniquity deleted the parserServicesTS branch January 17, 2019 16:33
JamesHenry pushed a commit that referenced this pull request Jan 17, 2019
JamesHenry pushed a commit that referenced this pull request Jan 17, 2019
JamesHenry pushed a commit that referenced this pull request Jan 18, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants