Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [prefer-reduce-type-parameter] handle already existing type params #3706

Merged
merged 1 commit into from Aug 30, 2021

Conversation

@yeonjuan
Copy link
Contributor

@yeonjuan yeonjuan commented Aug 3, 2021

fixes #3584

@typescript-eslint
Copy link

@typescript-eslint typescript-eslint bot commented Aug 3, 2021

Thanks for the PR, @yeonjuan!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Loading

@codecov
Copy link

@codecov codecov bot commented Aug 3, 2021

Codecov Report

Merging #3706 (e267d65) into master (4d3ae13) will increase coverage by 0.89%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3706      +/-   ##
==========================================
+ Coverage   92.68%   93.58%   +0.89%     
==========================================
  Files         327      147     -180     
  Lines       11351     7867    -3484     
  Branches     3201     2491     -710     
==========================================
- Hits        10521     7362    -3159     
+ Misses        369      161     -208     
+ Partials      461      344     -117     
Flag Coverage Δ
unittest 93.58% <100.00%> (+0.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-plugin/src/rules/prefer-reduce-type-parameter.ts 100.00% <100.00%> (ø)
...kages/scope-manager/src/lib/es2017.sharedmemory.ts
packages/experimental-utils/src/ts-eslint/Scope.ts
...ages/scope-manager/src/lib/es2016.array.include.ts
packages/visitor-keys/src/visitor-keys.ts
packages/scope-manager/src/lib/esnext.bigint.ts
packages/scope-manager/src/lib/dom.ts
packages/typescript-estree/src/convert-comments.ts
...mental-utils/src/eslint-utils/getParserServices.ts
...scope-manager/src/definition/VariableDefinition.ts
... and 171 more

Loading

@bradzacher bradzacher added the bug label Aug 3, 2021
Copy link
Member

@bradzacher bradzacher left a comment

thanks!

Loading

@bradzacher bradzacher merged commit 71dd273 into typescript-eslint:master Aug 30, 2021
11 checks passed
Loading
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants