Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove CLIEngine as it is deprecated and removed from ESLint v8 #3736

Closed

Conversation

coderaiser
Copy link

Removed deprecated and removed from ESLint v8 CLIEngine (#3735)

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @coderaiser!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Aug 15, 2021

Codecov Report

Merging #3736 (4dbb6a3) into master (a602caa) will decrease coverage by 0.10%.
The diff coverage is n/a.

❗ Current head 4dbb6a3 differs from pull request most recent head ef2014b. Consider uploading reports for the commit ef2014b to get more accurate results

@@            Coverage Diff             @@
##           master    #3736      +/-   ##
==========================================
- Coverage   92.68%   92.57%   -0.11%     
==========================================
  Files         327      187     -140     
  Lines       11351     8477    -2874     
  Branches     3201     2607     -594     
==========================================
- Hits        10521     7848    -2673     
+ Misses        369      262     -107     
+ Partials      461      367      -94     
Flag Coverage Δ
unittest 92.57% <ø> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/experimental-utils/src/ts-eslint/index.ts 100.00% <ø> (ø)
packages/scope-manager/src/lib/scripthost.ts
...es/scope-manager/src/scope/ConditionalTypeScope.ts
packages/scope-manager/src/lib/esnext.bigint.ts
...ages/scope-manager/src/referencer/ImportVisitor.ts
...ges/typescript-estree/src/create-program/shared.ts
packages/scope-manager/src/lib/es2015.core.ts
...e-manager/src/definition/TSEnumMemberDefinition.ts
packages/scope-manager/src/lib/base-config.ts
packages/scope-manager/src/scope/WithScope.ts
... and 130 more

@bradzacher bradzacher added breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package labels Aug 16, 2021
@bradzacher bradzacher added this to the 5.0.0 milestone Aug 16, 2021
@bradzacher bradzacher changed the base branch from master to v5 August 21, 2021 22:14
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much for your work on this!
However we're going to go with #3737 instead as it includes backwards-compatible support.
Until we drop support for ESLint v7 we'll need to remain backwards compatible.

@bradzacher bradzacher closed this Aug 22, 2021
@coderaiser coderaiser deleted the feature/eslint-8-support branch August 22, 2021 07:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking change This change will require a new major version to be released dependencies Issue about dependencies of the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants