-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove CLIEngine as it is deprecated and removed from ESLint v8 #3736
feat: remove CLIEngine as it is deprecated and removed from ESLint v8 #3736
Conversation
Thanks for the PR, @coderaiser! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #3736 +/- ##
==========================================
- Coverage 92.68% 92.57% -0.11%
==========================================
Files 327 187 -140
Lines 11351 8477 -2874
Branches 3201 2607 -594
==========================================
- Hits 10521 7848 -2673
+ Misses 369 262 -107
+ Partials 461 367 -94
Flags with carried forward coverage won't be shown. Click here to find out more. |
Nx Cloud ReportCI ran the following commands for commit ef2014b. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch Sent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks so much for your work on this!
However we're going to go with #3737 instead as it includes backwards-compatible support.
Until we drop support for ESLint v7 we'll need to remain backwards compatible.
Removed deprecated and removed from ESLint v8
CLIEngine
(#3735)