Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update nx to 12.9 and leverage NX_CLOUD_ENV_NAME #3935

Merged
merged 2 commits into from
Oct 3, 2021
Merged

chore: update nx to 12.9 and leverage NX_CLOUD_ENV_NAME #3935

merged 2 commits into from
Oct 3, 2021

Conversation

JamesHenry
Copy link
Member

No description provided.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JamesHenry!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Sep 28, 2021 •
edited

Nx Cloud Report

CI ran the following commands for commit 409524d. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 Node 10.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 10.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-internal
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 12.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin-tslint
#000000 Node 14.x - nx test @typescript-eslint/eslint-plugin
#000000 Node 10.x - nx test @typescript-eslint/parser
#000000 Node 10.x - nx test @typescript-eslint/experimental-utils
#000000 Node 10.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx test @typescript-eslint/parser
#000000 Node 10.x - nx test @typescript-eslint/visitor-keys
#000000 Node 10.x - nx test @typescript-eslint/typescript-estree
#000000 Node 12.x - nx test @typescript-eslint/experimental-utils
#000000 Node 12.x - nx test @typescript-eslint/scope-manager
#000000 Node 12.x - nx run-many --target=typecheck --all --parallel
#000000 Node 12.x - nx test @typescript-eslint/visitor-keys
#000000 Node 12.x - nx test @typescript-eslint/typescript-estree
#000000 Node 14.x - nx test @typescript-eslint/parser
#000000 Node 14.x - nx test @typescript-eslint/experimental-utils

Sent with 💌 from NxCloud.

@JamesHenry JamesHenry marked this pull request as ready for review September 28, 2021 14:35
@JamesHenry
Copy link
Member Author

@bradzacher as you can see in the Nx Cloud app comment above, this allows us to namespace the commands that ran so that it's much clearer what ran in what environment

@bradzacher bradzacher added the dependencies Issue about dependencies of the package label Oct 3, 2021
bradzacher
bradzacher approved these changes Oct 3, 2021
View reviewed changes
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's much cleaner!

@bradzacher bradzacher merged commit 972e2c2 into master Oct 3, 2021
@bradzacher bradzacher deleted the nx-cloud-env-prefix branch October 3, 2021 21:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bradzacher bradzacher bradzacher approved these changes

Assignees
No one assigned
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JamesHenry @bradzacher