Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental-utils): extract isTokenOfTypeWithConditions out of ast-utils' predicates #3977

merged 1 commit into from Nov 1, 2021


Copy link

#3976 needs to be merged first

Copy link

Thanks for the PR, @MichaelDeBoey!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #3977 (bf91a01) into master (9c8f9a8) will decrease coverage by 0.40%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #3977      +/-   ##
- Coverage   93.07%   92.66%   -0.41%     
  Files         295      194     -101     
  Lines       11069     8635    -2434     
  Branches     3218     2673     -545     
- Hits        10302     8002    -2300     
+ Misses        299      255      -44     
+ Partials      468      378      -90     
Flag Coverage Δ
unittest 92.66% <75.00%> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ckages/experimental-utils/src/ast-utils/helpers.ts 66.66% <60.00%> (ø)
...ges/experimental-utils/src/ast-utils/predicates.ts 91.11% <100.00%> (ø)
... and 167 more

Copy link
Contributor Author

@bradzacher Sorry for the delay, lots of ESLint plugins had some work 😅

Copy link

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -thanks for this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
enhancement New feature or request
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants