Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(eslint-plugin): Fix consistent-type-definitions README with correct usage of type #4039

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

kylepeeler
Copy link
Contributor

@kylepeeler kylepeeler commented Oct 21, 2021

Fix consistent-type-definitions README with correct usage of type, as of right now, the README conflicts with itself.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @kylepeeler!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@kylepeeler kylepeeler changed the title docs: Fix consistent-type-definitions README with correct usage of type docs(eslint-plugin): Fix consistent-type-definitions README with correct usage of type Oct 21, 2021
@codecov
Copy link

codecov bot commented Oct 21, 2021

Codecov Report

Merging #4039 (55a371c) into master (600d413) will increase coverage by 0.62%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4039      +/-   ##
==========================================
+ Coverage   92.69%   93.32%   +0.62%     
==========================================
  Files         333      151     -182     
  Lines       11400     7937    -3463     
  Branches     3242     2545     -697     
==========================================
- Hits        10567     7407    -3160     
+ Misses        363      180     -183     
+ Partials      470      350     -120     
Flag Coverage Δ
unittest 93.32% <100.00%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/typedef.ts 94.52% <100.00%> (+2.73%) ⬆️
packages/scope-manager/src/lib/es2020.promise.ts
packages/scope-manager/src/scope/FunctionScope.ts
packages/scope-manager/src/ScopeManager.ts
...kages/scope-manager/src/referencer/ClassVisitor.ts
...-estree/src/create-program/createProjectProgram.ts
packages/scope-manager/src/lib/es2019.full.ts
packages/scope-manager/src/scope/ModuleScope.ts
...utils/src/ast-utils/eslint-utils/PatternMatcher.ts
packages/scope-manager/src/lib/es2016.ts
... and 174 more

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄... Great catch, thanks!

@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Nov 1, 2021
@bradzacher bradzacher merged commit 475caa4 into typescript-eslint:master Nov 1, 2021
@kylepeeler kylepeeler deleted the patch-1 branch November 29, 2021 16:46
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants