New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): [no-var-requires] do not report require created from createRequire #4221
Conversation
…e should be ignored
Thanks for the PR, @asdf93074! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✔️ Deploy Preview for typescript-eslint ready! 🔨 Explore the source changes: d7f2d78 🔍 Inspect the deploy log: https://app.netlify.com/sites/typescript-eslint/deploys/61a1033bde0cb20008bb8a47 😎 Browse the preview: https://deploy-preview-4221--typescript-eslint.netlify.app |
Codecov Report
@@ Coverage Diff @@
## main #4221 +/- ##
==========================================
+ Coverage 92.73% 93.35% +0.62%
==========================================
Files 335 152 -183
Lines 11541 8057 -3484
Branches 3288 2590 -698
==========================================
- Hits 10703 7522 -3181
+ Misses 364 179 -185
+ Partials 474 356 -118
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this!
PR Checklist
Overview
Used this as a reference. Pretty much the same solution if I am not mistaken.