New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(website): filter out spam and add non-recurring donors #4758
docs(website): filter out spam and add non-recurring donors #4758
Conversation
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
packages/website/src/components/FinancialContributors/index.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick - one dangling "contributor" is rendered.
Do we want to "cap" the number of avatars shown?
I.e. we could just show the first 22 to fill out 2 lines.
Or we could dynamically show more lines but only show a new line if there's a nice amount like:
minPerLine = ???; // maybe 4?
numToShow = count;
if (count % 11 < minPerLine) {
numToShow = count - (count % 11);
}
packages/website/src/components/FinancialContributors/index.tsx
Outdated
Show resolved
Hide resolved
'Florian Studio', | ||
'java', | ||
'Loyalty Leo', | ||
'Penalty.com', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bradzacher that one trailing box is really irritating, isn't it? 😄
OpenCollective support said they'd stop the spam, but these accounts are still showing up.
Codecov Report
@@ Coverage Diff @@
## main #4758 +/- ##
==========================================
+ Coverage 93.96% 94.27% +0.31%
==========================================
Files 172 151 -21
Lines 9818 8220 -1598
Branches 3105 2672 -433
==========================================
- Hits 9225 7749 -1476
+ Misses 353 262 -91
+ Partials 240 209 -31
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yaaas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the PR description to match the new names and changed Supporter Plus to Gold Supporter in OC
PR Checklist
Overview
Updates the
generate-sponsors.ts
task file to merge OpenCollective data from two sources:account
: retrieves all orders given to uscollective
: retrieves collected individual member data, including their total donation countSplits the displayed data into three tiers: