Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): filter out spam and add non-recurring donors #4758

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Mar 28, 2022

PR Checklist

Overview

Updates the generate-sponsors.ts task file to merge OpenCollective data from two sources:

  • account: retrieves all orders given to us
  • collective: retrieves collected individual member data, including their total donation count

Splits the displayed data into three tiers:

  • Sponsor: Donors of $750 or more, and/or a monthly amount of $100 or more
  • Gold Supporter: Donors of $150 or more, and/or a monthly amount of $3 or more
  • Supporter: Donors of $50 or more

@nx-cloud
Copy link

nx-cloud bot commented Mar 28, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a4af58b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Mar 28, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit a4af58b
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62574208ceef1900090db87f
😎 Deploy Preview https://deploy-preview-4758--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review April 8, 2022 17:15
@bradzacher bradzacher added the documentation Documentation ("docs") that needs adding/updating label Apr 8, 2022
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Nitpick - one dangling "contributor" is rendered.

Do we want to "cap" the number of avatars shown?

I.e. we could just show the first 22 to fill out 2 lines.
Or we could dynamically show more lines but only show a new line if there's a nice amount like:

minPerLine = ???; // maybe 4?
numToShow = count;
if (count % 11 < minPerLine) {
  numToShow = count - (count % 11);
}

bradzacher
bradzacher previously approved these changes Apr 9, 2022
'Florian Studio',
'java',
'Loyalty Leo',
'Penalty.com',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#4758 (review)

@bradzacher that one trailing box is really irritating, isn't it? 😄

OpenCollective support said they'd stop the spam, but these accounts are still showing up.

Screenshot of the three tiers, including "Gold" sponsorships, with spam filtered out

@bradzacher
Copy link
Member

screen-20220412-232950.3.mp4

Checking on mobile (pixel 4) - the layout doesn't respect the thinner width properly.

Screenshot_20220412-233325.png

But looks good on a desktop (or desktop view on mobile lol)

@JoshuaKGoldberg
Copy link
Member Author

Grr, should be fixed now.
Screenshot of a mobile view properly wrapping sponsors columns

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #4758 (a4af58b) into main (18a81cb) will increase coverage by 0.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4758      +/-   ##
==========================================
+ Coverage   93.96%   94.27%   +0.31%     
==========================================
  Files         172      151      -21     
  Lines        9818     8220    -1598     
  Branches     3105     2672     -433     
==========================================
- Hits         9225     7749    -1476     
+ Misses        353      262      -91     
+ Partials      240      209      -31     
Flag Coverage Δ
unittest 94.27% <ø> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...estree/src/create-program/createIsolatedProgram.ts
packages/typescript-estree/src/convert.ts
packages/typescript-estree/src/convert-comments.ts
...ript-estree/src/create-program/createSourceFile.ts
...ges/typescript-estree/src/create-program/shared.ts
packages/typescript-estree/src/node-utils.ts
...-internal/src/rules/no-typescript-estree-import.ts
...-estree/src/create-program/createDefaultProgram.ts
packages/typescript-estree/src/simple-traverse.ts
...gin-internal/src/rules/no-poorly-typed-ts-props.ts
... and 11 more

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaaas

Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the PR description to match the new names and changed Supporter Plus to Gold Supporter in OC

@JoshuaKGoldberg JoshuaKGoldberg merged commit 8e17f56 into typescript-eslint:main Apr 14, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the sponsors-filter-expand branch April 14, 2022 13:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Documentation ("docs") that needs adding/updating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Website sponsor data includes low-donation spam
3 participants