Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(website): add missing typescript options to playground #4768

Merged
merged 2 commits into from
Mar 31, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
53 changes: 50 additions & 3 deletions packages/website/src/components/config/ConfigTypeScript.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import React, { useCallback } from 'react';
import tsConfigOptions from '../tsConfigOptions.json';
import React, { useCallback, useEffect, useState } from 'react';

import ConfigEditor from './ConfigEditor';
import ConfigEditor, { ConfigOptionsType } from './ConfigEditor';
import type { CompilerFlags } from '../types';
import { shallowEqual } from '../lib/shallowEqual';

Expand All @@ -11,11 +10,59 @@ interface ModalTypeScriptProps {
readonly config?: CompilerFlags;
}

interface OptionDeclarations {
name: string;
type?: unknown;
category?: { message: string };
description?: { message: string };
}

function checkOptions(item: [string, unknown]): item is [string, boolean] {
return typeof item[1] === 'boolean';
}

function ConfigTypeScript(props: ModalTypeScriptProps): JSX.Element {
const [tsConfigOptions, updateOptions] = useState<ConfigOptionsType[]>([]);

useEffect(() => {
if (window.ts) {
updateOptions(
Object.values(
// @ts-expect-error: definition is not fully correct
(window.ts.optionDeclarations as OptionDeclarations[])
.filter(
item =>
item.type === 'boolean' &&
item.description &&
item.category &&
![
'Command-line Options',
'Modules',
'Projects',
'Compiler Diagnostics',
'Editor Support',
'Output Formatting',
'Watch and Build Modes',
'Source Map Options',
].includes(item.category.message),
)
.reduce<Record<string, ConfigOptionsType>>((group, item) => {
const category = item.category!.message;
group[category] = group[category] ?? {
heading: category,
fields: [],
};
group[category].fields.push({
key: item.name,
label: item.description!.message,
});
return group;
}, {}),
),
);
}
}, [props.isOpen]);

const onClose = useCallback(
(newConfig: Record<string, unknown>) => {
const cfg = Object.fromEntries(
Expand Down
7 changes: 6 additions & 1 deletion packages/website/src/components/editor/LoadedEditor.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,13 @@ export const LoadedEditor: React.FC<LoadedEditorProps> = ({

useEffect(() => {
sandboxInstance.setCompilerSettings({
noResolve: true,
strict: true,
target: main.languages.typescript.ScriptTarget.ESNext,
module: main.languages.typescript.ModuleKind.ESNext,
lib: ['ESNext'],
...tsConfig,
jsx: jsx ? 2 : 0,
jsx: jsx ? main.languages.typescript.JsxEmit.React : undefined,
});
}, [jsx, sandboxInstance, JSON.stringify(tsConfig) /* todo: better way? */]);

Expand Down
97 changes: 0 additions & 97 deletions packages/website/src/components/tsConfigOptions.json

This file was deleted.