Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): do not update lib target on every config change #4770

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Mar 31, 2022

Overview

Fix issue reported in #4765 (comment)

https://typescript-eslint.io/play/#ts=4.6.2&sourceType=module&code=CYUwxgNghgTiAEAzArgOzAFwJYHtXwDcctgB5GABRhwFssBnEAClgHMAueJpgSngF4AfIWLA+AHy68BwqrQYgAPERKCePTiuABuIA&rules=N4XyA&tsConfig=N4XyA

Cannot find name 'Promise'. Do you need to change your target library? Try changing the 'lib' compiler option to 'es2015' or later.(2583)

Tests

cc @bradzacher

@armano2 armano2 added the package: website Issues related to the @typescript-eslint website label Mar 31, 2022
@nx-cloud
Copy link

nx-cloud bot commented Mar 31, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 3f02823. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@typescript-eslint

This comment was marked as resolved.

@netlify
Copy link

netlify bot commented Mar 31, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 3f02823
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62460de4c2334a000ca71599
😎 Deploy Preview https://deploy-preview-4770--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@armano2 armano2 changed the title fix(website): correct issue created by changes from #4765 and #4768 fix(website): do not update lib target on every config change Mar 31, 2022
@bradzacher bradzacher merged commit f102f23 into main Mar 31, 2022
@armano2 armano2 deleted the fix/playground-lib-override-issue branch March 31, 2022 20:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
package: website Issues related to the @typescript-eslint website
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants