feat(eslint-plugin): Contextual non-null [no-unnecessary-type-assertion] #478
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix handling of "used before assigned" variables:
Fixes #453
Note: this fix isn't perfect, but it's "good enough".
The type checker exposes no mechanism to detect this case (but it has code for it: https://raw.githubusercontent.com/Microsoft/TypeScript/84076a55351684296f7b3f1d2715690acbe8039f/src/compiler/checker.ts and search for
Variable_0_is_used_before_being_assigned
)See: microsoft/TypeScript#31124 and microsoft/TypeScript#20221
Also adds handling for contextually unnecessary non-null operator based on where it's used:
Will look at adding contextually unnecessary support to the
as
branch later - this PR is big enough as is...