Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(eslint-plugin): fix typo in prefer-readonly-parameter-types #4997

Merged

Conversation

neilbryson
Copy link
Contributor

PR Checklist

Overview

This only fixes the typo error acceceptsCallback => acceptsCallback in prefer-readonly-parameter-types

@nx-cloud
Copy link

nx-cloud bot commented May 17, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4544884. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 43 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @neilbryson!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented May 17, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4544884
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6282f86c2f30b90009fb3dcf
😎 Deploy Preview https://deploy-preview-4997--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #4997 (4544884) into main (f256357) will increase coverage by 2.47%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4997      +/-   ##
==========================================
+ Coverage   91.76%   94.23%   +2.47%     
==========================================
  Files         229      154      -75     
  Lines       10635     8308    -2327     
  Branches     3293     2706     -587     
==========================================
- Hits         9759     7829    -1930     
+ Misses        592      263     -329     
+ Partials      284      216      -68     
Flag Coverage Δ
unittest 94.23% <ø> (+2.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/utils/src/eslint-utils/nullThrows.ts
packages/utils/src/ts-eslint-scope/Definition.ts
packages/utils/src/ts-eslint-scope/ScopeManager.ts
packages/utils/src/eslint-utils/RuleTester.ts
packages/utils/src/ast-utils/index.ts
packages/visitor-keys/src/visitor-keys.ts
packages/utils/src/ts-eslint/Scope.ts
packages/eslint-plugin-tslint/src/custom-linter.ts
packages/typescript-estree/src/version-check.ts
packages/type-utils/src/getTokenAtPosition.ts
... and 65 more

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙂 good catch, thanks!

@JoshuaKGoldberg JoshuaKGoldberg merged commit e91a4a1 into typescript-eslint:main May 17, 2022
@neilbryson neilbryson deleted the fix/typo-prefer-readonly branch May 17, 2022 02:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants