-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump Docusaurus to 2.0 #5377
Conversation
Thanks for the PR, @Josh-Cena! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
The errors are because Babel now treats named imports with |
why did bumping the docusaurus version break the for the lint errors - you should be able to convert the "bad" cases to not use prettier by adding a template tag:
|
It's because Docusaurus depends on the newest version of Babel and it gets deduplicated. Didn't see the lint errors, will fix those |
Does docusaurus have a peer dep on babel? |
No—it's a hard dep. This can wait a bit so we can fix the parser first. |
About the Babel alignment issue, this is being asked here: tc39/proposal-json-modules#27 maybe it will eventually be a non-problem. |
To make this all easier to manage - we'll merge #5491 first so that we have the autoformatting merged and we can update all other PRs at our own pace, then we can review the docusaurus changes in isolation and merge without trying to keep this PR up-to-date with main. |
to fix the test failure - you should just move the test folder into the folder called then i reckon this is good to go? |
Signed-off-by: Joshua Chen <sidachen2003@gmail.com>
Might want to make it a separate PR, but anyway, here it is. |
sorry - I probably should have mentioned you'll need to re-run the test to update the fixtures: $ cd packages/ast-spec
$ yarn jest tests/fixtures.test.ts -u |
Codecov Report
@@ Coverage Diff @@
## main #5377 +/- ##
==========================================
- Coverage 91.74% 91.74% -0.01%
==========================================
Files 366 364 -2
Lines 12373 12366 -7
Branches 3611 3611
==========================================
- Hits 11352 11345 -7
Misses 669 669
Partials 352 352
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Checklist
Overview
Manual bump for two dependencies.
Bumping Docusaurus so I can work on #5366