Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump Docusaurus to 2.0 #5377

Merged
merged 11 commits into from
Aug 24, 2022
Merged

Conversation

Josh-Cena
Copy link
Member

@Josh-Cena Josh-Cena commented Jul 25, 2022

PR Checklist

Overview

Manual bump for two dependencies.

Bumping Docusaurus so I can work on #5366

@nx-cloud
Copy link

nx-cloud bot commented Jul 25, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b539c32. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @Josh-Cena!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jul 25, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit b539c32
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6306060c179228000876efed
😎 Deploy Preview https://deploy-preview-5377--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Josh-Cena
Copy link
Member Author

Josh-Cena commented Jul 25, 2022

The errors are because Babel now treats named imports with type: "json" as early syntax error (same problem in #5371). I don't know how we should fix this (ideally tighten our own parser), but that should be in a separate PR before this gets merged.

@bradzacher bradzacher added the dependencies Issue about dependencies of the package label Jul 25, 2022
@bradzacher
Copy link
Member

bradzacher commented Jul 25, 2022

why did bumping the docusaurus version break the ast-spec tests?
shouldn't the version ranges be independent?

for the lint errors - you should be able to convert the "bad" cases to not use prettier by adding a template tag:

code: 'test',
// becomes
code: noFormat`test`,

@Josh-Cena
Copy link
Member Author

shouldn't the version ranges be independent?

It's because Docusaurus depends on the newest version of Babel and it gets deduplicated.

Didn't see the lint errors, will fix those

@bradzacher
Copy link
Member

Does docusaurus have a peer dep on babel?
Can we pin our local version of babel so that we can upgrade them independently?

@Josh-Cena
Copy link
Member Author

Josh-Cena commented Jul 26, 2022

No—it's a hard dep. This can wait a bit so we can fix the parser first.

@Josh-Cena Josh-Cena changed the title chore(deps): bump Docusaurus to rc.1 and Prettier to 2.7 chore(deps): bump Docusaurus to 2.0 and Prettier to 2.7 Aug 1, 2022
@Josh-Cena
Copy link
Member Author

About the Babel alignment issue, this is being asked here: tc39/proposal-json-modules#27 maybe it will eventually be a non-problem.

@bradzacher bradzacher changed the title chore(deps): bump Docusaurus to 2.0 and Prettier to 2.7 chore: bump Docusaurus to 2.0 and Prettier to 2.7 Aug 17, 2022
@bradzacher
Copy link
Member

To make this all easier to manage - we'll merge #5491 first so that we have the autoformatting merged and we can update all other PRs at our own pace, then we can review the docusaurus changes in isolation and merge without trying to keep this PR up-to-date with main.

@bradzacher bradzacher changed the title chore: bump Docusaurus to 2.0 and Prettier to 2.7 chore: bump Docusaurus to 2.0 Aug 17, 2022
@bradzacher
Copy link
Member

to fix the test failure - you should just move the test folder into the folder called _error_.

then i reckon this is good to go?

@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Aug 21, 2022
Signed-off-by: Joshua Chen <sidachen2003@gmail.com>
@Josh-Cena
Copy link
Member Author

Might want to make it a separate PR, but anyway, here it is.

@bradzacher
Copy link
Member

sorry - I probably should have mentioned you'll need to re-run the test to update the fixtures:

$ cd packages/ast-spec
$ yarn jest tests/fixtures.test.ts -u

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Aug 24, 2022
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #5377 (b539c32) into main (9c3e58a) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5377      +/-   ##
==========================================
- Coverage   91.74%   91.74%   -0.01%     
==========================================
  Files         366      364       -2     
  Lines       12373    12366       -7     
  Branches     3611     3611              
==========================================
- Hits        11352    11345       -7     
  Misses        669      669              
  Partials      352      352              
Flag Coverage Δ
unittest 91.74% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/visitor-keys/src/visitor-keys.ts
packages/visitor-keys/src/get-keys.ts

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tucci_thats_good

@bradzacher bradzacher merged commit 6ab767b into typescript-eslint:main Aug 24, 2022
@Josh-Cena Josh-Cena deleted the bump-deps branch August 24, 2022 11:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Issue about dependencies of the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants