Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: simplify prettier include lists #5380

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

Switches the hardcoded lists of extensions to just the recommended . as per #5060 (comment).

Also removes the ignoring of .github/. I don't know why we'd want to skip formatting those files.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@nx-cloud
Copy link

nx-cloud bot commented Jul 25, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 4cd46bb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Jul 25, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 4cd46bb
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62efc201f59802000883b36e
😎 Deploy Preview https://deploy-preview-5380--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review July 25, 2022 23:03
@bradzacher bradzacher added the repo maintenance things to do with maintenance of the repo, and not with code/docs label Aug 7, 2022
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@bradzacher
Copy link
Member

Also removes the ignoring of .github/. I don't know why we'd want to skip formatting those files

I think that there was a bug with the YAML handling or something in the past? I don't remember exactly!

@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) August 7, 2022 13:45
@JoshuaKGoldberg JoshuaKGoldberg merged commit df4e05e into typescript-eslint:main Aug 7, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the simplify-prettier-include-lists branch August 7, 2022 14:09
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
repo maintenance things to do with maintenance of the repo, and not with code/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: simplify prettier include lists
2 participants