Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-use-before-define] add "allowNamedExports" option #5397

Merged

Conversation

JesuisTong
Copy link
Contributor

@JesuisTong JesuisTong commented Jul 29, 2022

PR Checklist

Overview

Fixes #5324

[no-use-before-define] Add allowNamedExports option to adapter eslint@8.17.0

allowNamedExports?: boolean;

@nx-cloud
Copy link

nx-cloud bot commented Jul 29, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ead858d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Jul 29, 2022

Thanks for the PR, @JesuisTong!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@netlify
Copy link

netlify bot commented Jul 29, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit ead858d
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/62e35c5ea47480000852b92a
😎 Deploy Preview https://deploy-preview-5397--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Jul 29, 2022

Codecov Report

Merging #5397 (ead858d) into main (ad26b74) will increase coverage by 2.46%.
The diff coverage is 94.11%.

@@            Coverage Diff             @@
##             main    #5397      +/-   ##
==========================================
+ Coverage   91.36%   93.82%   +2.46%     
==========================================
  Files         132      290     +158     
  Lines        1494     9981    +8487     
  Branches      226     3004    +2778     
==========================================
+ Hits         1365     9365    +8000     
- Misses         65      335     +270     
- Partials       64      281     +217     
Flag Coverage Δ
unittest 93.82% <94.11%> (+2.46%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...es/eslint-plugin/src/rules/no-use-before-define.ts 93.39% <94.11%> (ø)
packages/eslint-plugin/src/configs/recommended.ts 100.00% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/no-invalid-this.ts 80.00% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-loop-func.ts 98.11% <0.00%> (ø)
...t-plugin/src/rules/prefer-reduce-type-parameter.ts 100.00% <0.00%> (ø)
...ges/eslint-plugin/src/rules/no-misused-promises.ts 98.35% <0.00%> (ø)
...t-plugin/src/rules/class-literal-property-style.ts 100.00% <0.00%> (ø)
...nt-plugin/src/rules/switch-exhaustiveness-check.ts 97.95% <0.00%> (ø)
packages/eslint-plugin/src/rules/no-unsafe-call.ts 100.00% <0.00%> (ø)
...ackages/eslint-plugin/src/rules/no-var-requires.ts 90.00% <0.00%> (ø)
... and 149 more

JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Jul 29, 2022
Copy link
Contributor

@JoshuaKGoldberg JoshuaKGoldberg left a comment

LGTM, thanks!

I tried playing around with isForbidden to keep from adding the new if (!options.allowNamedExports ... block but couldn't find any logic to do so. Ah well.

packages/eslint-plugin/src/rules/no-use-before-define.ts Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg merged commit ad412cd into typescript-eslint:main Jul 29, 2022
41 checks passed
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Aug 9, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.31.0` -> `5.32.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/5.31.0/5.32.0) |
| [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint) | devDependencies | minor | [`5.31.0` -> `5.32.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/5.31.0/5.32.0) |

---

### Release Notes

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.32.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#&#8203;5320-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5310v5320-2022-08-01)

[Compare Source](typescript-eslint/typescript-eslint@v5.31.0...v5.32.0)

##### Features

-   **eslint-plugin:** \[no-use-before-define] add "allowNamedExports" option ([#&#8203;5397](typescript-eslint/typescript-eslint#5397)) ([ad412cd](typescript-eslint/typescript-eslint@ad412cd))

</details>

<details>
<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.32.0`](https://github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#&#8203;5320-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5310v5320-2022-08-01)

[Compare Source](typescript-eslint/typescript-eslint@v5.31.0...v5.32.0)

**Note:** Version bump only for package [@&#8203;typescript-eslint/parser](https://github.com/typescript-eslint/parser)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

 **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE0My4xIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1486
Reviewed-by: Epsilon_02 <epsilon_02@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-use-before-define] Missing allowNamedExports option from base rule
2 participants