Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(scope-manager): ignore ECMA version" #5888

merged 1 commit into from
Oct 26, 2022


Copy link

Reverts #5881

Copy link

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

Copy link

nx-cloud bot commented Oct 26, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 39d58a6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

Copy link

netlify bot commented Oct 26, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 39d58a6
🔍 Latest deploy log
😎 Deploy Preview
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review October 26, 2022 02:53
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #5888 (39d58a6) into main (3b8d449) will increase coverage by 0.01%.
The diff coverage is 88.88%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5888      +/-   ##
+ Coverage   91.34%   91.36%   +0.01%     
  Files         364      364              
  Lines       12123    12134      +11     
  Branches     3530     3540      +10     
+ Hits        11074    11086      +12     
+ Misses        750      748       -2     
- Partials      299      300       +1     
Flag Coverage Δ
unittest 91.36% <88.88%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/scope-manager/src/analyze.ts 65.38% <75.00%> (+7.48%) ⬆️
packages/scope-manager/src/ScopeManager.ts 79.74% <100.00%> (+2.53%) ⬆️
...ackages/scope-manager/src/referencer/Referencer.ts 95.96% <100.00%> (+0.06%) ⬆️

@JoshuaKGoldberg JoshuaKGoldberg merged commit 2ee81df into main Oct 26, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the revert-5881-scope-manager-ignore-ecma-version branch October 26, 2022 03:08
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Nov 2, 2022
This PR contains the following updates:

| Package | Type | Update | Change |
| [@typescript-eslint/eslint-plugin]( | devDependencies | minor | [`5.41.0` -> `5.42.0`]( |
| [@typescript-eslint/parser]( | devDependencies | minor | [`5.41.0` -> `5.42.0`]( |


### Release Notes

<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/eslint-plugin)</summary>

### [`v5.42.0`](;5420-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5410v5420-2022-10-31)

[Compare Source](typescript-eslint/typescript-eslint@v5.41.0...v5.42.0)

##### Bug Fixes

-   **ast-spec:** add TSQualifiedName to TypeNode union ([#&#8203;5906](typescript-eslint/typescript-eslint#5906)) ([5c316c1](typescript-eslint/typescript-eslint@5c316c1))
-   **eslint-plugin:** \[no-extra-parens] handle type assertion in extends clause ([#&#8203;5901](typescript-eslint/typescript-eslint#5901)) ([8ed7219](typescript-eslint/typescript-eslint@8ed7219))

##### Features

-   **eslint-plugin:** \[member-ordering] add natural sort order ([#&#8203;5662](typescript-eslint/typescript-eslint#5662)) ([1eaae09](typescript-eslint/typescript-eslint@1eaae09))
-   **eslint-plugin:** \[no-invalid-void-type] better report message for void used as a constituent inside a function return type ([#&#8203;5274](typescript-eslint/typescript-eslint#5274)) ([d806bda](typescript-eslint/typescript-eslint@d806bda))


<summary>typescript-eslint/typescript-eslint (@&#8203;typescript-eslint/parser)</summary>

### [`v5.42.0`](;5420-httpsgithubcomtypescript-eslinttypescript-eslintcomparev5410v5420-2022-10-31)

[Compare Source](typescript-eslint/typescript-eslint@v5.41.0...v5.42.0)

##### Features

-   **scope-manager:** ignore ECMA version ([#&#8203;5881](typescript-eslint/typescript-eslint#5881)) ([3b8d449](typescript-eslint/typescript-eslint@3b8d449))

##### Reverts

-   Revert "feat(scope-manager): ignore ECMA version" ([#&#8203;5888](typescript-eslint/typescript-eslint#5888)) ([2ee81df](typescript-eslint/typescript-eslint@2ee81df)), closes [#&#8203;5888](typescript-eslint/typescript-eslint#5888) [#&#8203;5881](typescript-eslint/typescript-eslint#5881)



### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.


 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box


This PR has been generated by [Renovate Bot](

Co-authored-by: cabr2-bot <>
Reviewed-by: Epsilon_02 <>
Co-authored-by: Calciumdibromid Bot <>
Co-committed-by: Calciumdibromid Bot <>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

1 participant