Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [keyword-spacing] Support spacing in import-type syntax #5977

Conversation

omril1
Copy link
Contributor

@omril1 omril1 commented Nov 12, 2022

PR Checklist

Overview

Add a space between type token and * or { tokens when after option is true, and remove when after is false

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @omril1!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Nov 12, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 616fd2c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


Successfully ran 46 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Nov 12, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 616fd2c
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/6373ba3541c8e50008528a19
😎 Deploy Preview https://deploy-preview-5977--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #5977 (76d6d84) into main (8af1b4d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Current head 76d6d84 differs from pull request most recent head 616fd2c. Consider uploading reports for the commit 616fd2c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5977   +/-   ##
=======================================
  Coverage   91.41%   91.42%           
=======================================
  Files         365      365           
  Lines       12328    12337    +9     
  Branches     3607     3609    +2     
=======================================
+ Hits        11270    11279    +9     
  Misses        753      753           
  Partials      305      305           
Flag Coverage Δ
unittest 91.42% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/eslint-plugin/src/rules/keyword-spacing.ts 100.00% <100.00%> (ø)

@omril1 omril1 changed the title feat/issue5362-keyword-spacing---support-import-type-syntax feat: keyword-spacing - Support spacing in import-type syntax Nov 13, 2022
@omril1 omril1 changed the title feat: keyword-spacing - Support spacing in import-type syntax feat(eslint-lugin) [keyword-spacing] Support spacing in import-type syntax Nov 13, 2022
@bradzacher bradzacher changed the title feat(eslint-lugin) [keyword-spacing] Support spacing in import-type syntax feat(eslint-lugin): [keyword-spacing] Support spacing in import-type syntax Nov 15, 2022
@bradzacher bradzacher changed the title feat(eslint-lugin): [keyword-spacing] Support spacing in import-type syntax feat(eslint-plugin): [keyword-spacing] Support spacing in import-type syntax Nov 15, 2022
JoshuaKGoldberg
JoshuaKGoldberg previously approved these changes Nov 15, 2022
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for sending this in @omril1!

packages/eslint-plugin/tests/rules/keyword-spacing.test.ts Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg enabled auto-merge (squash) November 15, 2022 16:11
@JoshuaKGoldberg JoshuaKGoldberg merged commit 6a735e1 into typescript-eslint:main Nov 15, 2022
34 of 37 checks passed
@omril1 omril1 deleted the feat/issue5362-keyword-spacing---support-import-type-syntax branch November 15, 2022 18:13
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: [keyword-spacing] Make it possible to force a space after import type
2 participants