Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): [no-unsafe-enum-comparison] add rule #6107
feat(eslint-plugin): [no-unsafe-enum-comparison] add rule #6107
Changes from 98 commits
481fb44
5776a01
094c90e
311b1f8
ac5e6d9
7d55248
74af3d1
1eb70ee
cf006fd
4d7f3fe
2bbc2b7
75c2252
3976fdc
2406d03
4244376
8b4dcdc
12f8120
e638718
aef971a
75f60b9
d784aa0
811de98
9a71d45
f93a02a
2ced9f8
0695c1b
7272a95
6ed1f66
83c70e3
0ff3096
ddebded
c8b239b
90981a9
32dec63
d0dbcbb
c63c518
c5cf7f3
1b26d74
6e4f705
a0a2ee6
dbae5db
16965d9
8b8f8f8
5f437cc
b1dbeb6
25caa05
f42de61
a866ddd
61cf107
304d796
83c5f30
23ac918
098d732
99424e1
0de3b26
2d488cc
15dc3df
a3d0122
5cd8fa7
a236085
c357432
2395998
2851c3b
149c049
cf7c9b7
3b2fa57
6c43f71
af7d5da
a50f6e1
85563be
ee96ce5
943bf9f
7679c4a
871e9ca
f861606
cbe9e90
c37165c
3f37c67
c942261
b2947f9
a7772d2
4204a60
89bcd73
4f13db4
4706e4f
be144e3
e4ac325
62ccdb1
da7501a
83c33cb
a3e6236
f1071fa
680293a
51bc2b1
14cceea
bc65e3c
adf6f2e
68ad65c
57376a7
559c0ab
b1c9bec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing the recommended configs is considered a breaking change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh shoot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah wait, per https://typescript-eslint.io/linting/configs,
strict
isn't considered stable. It's not in our "recommended" configs list. 😌Still filing #6890 just in case.
Check warning on line 17 in packages/eslint-plugin/src/rules/enum-utils/shared.ts
Codecov / codecov/patch
packages/eslint-plugin/src/rules/enum-utils/shared.ts#L17