Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental-utils): console.warn on import of experimental-utils #6179


Copy link

@kball kball commented Dec 7, 2022

PR Checklist


Adds a console.warn upon importing from experimental-utils, as well as a test to verify

Copy link

nx-cloud bot commented Dec 7, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0d29d2b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

Copy link

Thanks for the PR, @kball!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on

@kball kball changed the title feat(experimental-utils) console.warn on import of experimental-utils feat(experimental-utils): console.warn on import of experimental-utils Dec 7, 2022
Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 this is great, thanks!

I went back and forth in my mind a bit as to whether this is a feat or a chore... but I like the increased visibility that a feat brings.

@JoshuaKGoldberg JoshuaKGoldberg merged commit 0b7476b into typescript-eslint:v6 Dec 8, 2022
34 of 35 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2022
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Feb 22, 2023
@typescript-eslint typescript-eslint unlocked this conversation Mar 14, 2023
Copy link

Just a heads up @kball, we ended up removing the package entirely in v6: #6179. Sorry to take up your time with something that didn't end up shipping. But I hope you enjoyed the experience nonetheless and are up for contributing again! 😄

Copy link
Contributor Author

kball commented Mar 14, 2023 via email

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants