Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: more aggressively clean local dev caches #6197

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

PR Checklist

Overview

I took another hard look at local build caching w.r.t. #6144 and #6163. I think the issue was that out-of-date files kept getting out of date, most often packages/types/src/generated/ast-spec.ts. This adds two layers of protection:

  • For specifically the types package, also cleans src/generated/ in yarn clean: since it's generated similar to dist/.
  • Generally runs yarn clean in the postinstall script: as a backup precaution to make sure if you've pulled in build/cache changes, to wipe more things that might be out of date now. Ideally Nx should be caching them when the next line's yarn build runs anyway.

I moved the BaseNode JSDoc comments to below its type as a way to test this. They show up erroneously in the built output so this is a good change anyway. And, #5252 will blow those changes away once v6 lands.

@nx-cloud
Copy link

nx-cloud bot commented Dec 11, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit abb6055. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Dec 11, 2022

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit abb6055
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63962a2d257ac40009932b79
😎 Deploy Preview https://deploy-preview-6197--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review December 11, 2022 19:21
Copy link
Member

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 88cd9ca into typescript-eslint:main Dec 12, 2022
@JoshuaKGoldberg JoshuaKGoldberg deleted the repo-clean-more branch December 12, 2022 16:52
omril1 pushed a commit to omril1/typescript-eslint that referenced this pull request Dec 16, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Build break in local development on main
2 participants