chore: run website tests against netlify deployment

.github/workflows/ci.yml

@@ -179,26 +179,38 @@ jobs:
       contents: read # to fetch code (actions/checkout)
 
     name: Website tests
+    # We technically do not need to wait for build within the pipeline any more because the build we care about is happening within Netlify, however,
+    # it is highly likely that if the CI one fails, the Netlify one will as well, so in order to not waste unncessary Github Actions minutes/resources,
+    # we do still keep this requirement here.
     needs: [build]
     runs-on: ubuntu-latest
     steps:
       - name: Checkout
         uses: actions/checkout@v3
         with:
           fetch-depth: 2
+
       - name: Install
         uses: ./.github/actions/prepare-install
         with:
           node-version: ${{ env.PRIMARY_NODE_VERSION }}
-      - name: Build
-        uses: ./.github/actions/prepare-build
 
       - name: Install Playwright Browsers
         run: npx playwright install --with-deps
 
-      - name: Run Playwright tests
+      - name: Wait for Netlify deployment
+        uses: probablyup/wait-for-netlify-action@3.2.0
+        id: waitForDeployment
+        with:
+          site_id: '128d21c7-b2fe-45ad-b141-9878fcf5de3a'
+        env:
+          NETLIFY_TOKEN: ${{ secrets.NETLIFY_TOKEN }}
+
+      - name: Run Playwright tests against the Netlify deployment
         run: yarn playwright test --reporter=list
         working-directory: packages/website
+        env:
+          PLAYWRIGHT_TEST_BASE_URL: ${{ steps.waitForDeployment.outputs.url }}
 
       - if: always()
         uses: actions/upload-artifact@v3

packages/website/playwright.config.ts

@@ -8,7 +8,7 @@ const config: PlaywrightTestConfig = {
   retries: 0,
   testDir: './tests',
   use: {
-    baseURL: 'http://localhost:3000',
+    baseURL: process.env.PLAYWRIGHT_TEST_BASE_URL || 'http://localhost:3000',
     trace: 'on-first-retry',
   },
   projects: [
@@ -19,11 +19,13 @@ const config: PlaywrightTestConfig = {
       },
     },
   ],
-  webServer: {
-    command: 'yarn start',
-    port: 3000,
-    reuseExistingServer: !process.env.CI,
-  },
+  webServer: process.env.PLAYWRIGHT_TEST_BASE_URL
+    ? undefined
+    : {
+        command: 'yarn start',
+        port: 3000,
+        reuseExistingServer: !process.env.CI,
+      },
   workers: process.env.CI ? 1 : undefined,
 };
 

packages/website/tests/index.spec.ts

@@ -15,8 +15,6 @@ test.describe('Website', () => {
       }
     });
     await page.goto('/');
-    expect(errorMessages).toStrictEqual([
-      "[error] Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot",
-    ]);
+    expect(errorMessages).toStrictEqual([]);
   });
 });