Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(website): used lighter primary color for table of contents active links in dark mode #6364

Merged

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Jan 22, 2023

Overview

Quick little bug I noticed working in dark mode. This makes the ToC color match the link color for general body text and the left side nav.

Before After
Before screenshot of middling purple text on dark gray background After screenshot of light purple text on dark gray background

@nx-cloud
Copy link

nx-cloud bot commented Jan 22, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cb848cc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 46 targets

Sent with 💌 from NxCloud.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jan 22, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit cb848cc
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63f59e3910d2e300071b1f2e
😎 Deploy Preview https://deploy-preview-6364--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Josh-Cena
Copy link
Member

I don't think overriding the active color is the best fix. Note that in dark mode, we already use a lighter color as the primary color—hence why the sidebar and content links are accessible without CSS overrides. I would need to look into why it doesn't work for the TOC.

@Josh-Cena
Copy link
Member

OK scratch that: we actually do override the link color in dark mode...

--ifm-link-color: var(--ifm-color-primary-light);

Should I suggest lightening the primary color instead? We seem to be using this light blue in more places than the actual primary color.

@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft January 23, 2023 12:39
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review February 22, 2023 04:46
@JoshuaKGoldberg JoshuaKGoldberg requested review from Josh-Cena and removed request for Josh-Cena February 25, 2023 05:00
@JoshuaKGoldberg JoshuaKGoldberg changed the title chore(website): used lighter primary color for table of contents active links chore(website): used lighter primary color for table of contents active links in dark mode Feb 25, 2023
@JoshuaKGoldberg JoshuaKGoldberg merged commit 133a10c into typescript-eslint:main Mar 12, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants