New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(website): used lighter primary color for table of contents active links in dark mode #6364
chore(website): used lighter primary color for table of contents active links in dark mode #6364
Conversation
Thanks for the PR, @JoshuaKGoldberg! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
I don't think overriding the active color is the best fix. Note that in dark mode, we already use a lighter color as the primary color—hence why the sidebar and content links are accessible without CSS overrides. I would need to look into why it doesn't work for the TOC. |
OK scratch that: we actually do override the link color in dark mode...
Should I suggest lightening the primary color instead? We seem to be using this light blue in more places than the actual primary color. |
Overview
Quick little bug I noticed working in dark mode. This makes the ToC color match the link color for general body text and the left side nav.