Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable one-var rule #6410

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

sviat9440
Copy link
Contributor

PR Checklist

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @sviat9440!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@nx-cloud
Copy link

nx-cloud bot commented Feb 2, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cc14694. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 47 targets

Sent with 💌 from NxCloud.

@netlify
Copy link

netlify bot commented Feb 2, 2023

Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit cc14694
🔍 Latest deploy log https://app.netlify.com/sites/typescript-eslint/deploys/63db8351c15cb50009748e6e
😎 Deploy Preview https://deploy-preview-6410--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks @sviat9440!

I know I've been a little slow on your PRs in the past, so it brings me joy to get this one in quickly. 😅

@JoshuaKGoldberg JoshuaKGoldberg merged commit a948729 into typescript-eslint:main Feb 2, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo: Enable one-var internally
2 participants